Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add some breaks and resize images that were across multiple PDF pages #120

Merged
merged 7 commits into from
Apr 18, 2024
Merged

Add some breaks and resize images that were across multiple PDF pages #120

merged 7 commits into from
Apr 18, 2024

Conversation

jaclyn-taroni
Copy link
Member

@jaclyn-taroni jaclyn-taroni commented Apr 18, 2024 •
edited
Loading

I'm optimizing for the PDF version of the manuscript with these changes. Please review that output particularly carefully.

@jaclyn-taroni jaclyn-taroni marked this pull request as ready for review April 18, 2024 15:02
@github-actions GitHub Actions
Copy link

Click the link below to download the manuscript build as a ZIP file.
This build is associated with commit 28c0625.

Manuscript build

There were 1 spelling errors.
Check the build link above for details.

@github-actions GitHub Actions
Copy link

Click the link below to download the manuscript build as a ZIP file.
This build is associated with commit 7967f42.

Manuscript build

There were 1 spelling errors.
Check the build link above for details.

@jaclyn-taroni jaclyn-taroni changed the title [WIP] Add page breaks and resize images that are across multiple pages [WIP] Add some breaks and resize images that were across multiple PDF pages Apr 18, 2024
@github-actions GitHub Actions
Copy link

Click the link below to download the manuscript build as a ZIP file.
This build is associated with commit ff7a307.

Manuscript build

There were 1 spelling errors.
Check the build link above for details.

@github-actions GitHub Actions
Copy link

Click the link below to download the manuscript build as a ZIP file.
This build is associated with commit 4924d73.

Manuscript build

There were 1 spelling errors.
Check the build link above for details.

@github-actions GitHub Actions
Copy link

Click the link below to download the manuscript build as a ZIP file.
This build is associated with commit 12a8234.

Manuscript build

There were 1 spelling errors.
Check the build link above for details.

@jaclyn-taroni jaclyn-taroni changed the title [WIP] Add some breaks and resize images that were across multiple PDF pages Add some breaks and resize images that were across multiple PDF pages Apr 18, 2024
@github-actions GitHub Actions
Copy link

Click the link below to download the manuscript build as a ZIP file.
This build is associated with commit 07dfc3a.

Manuscript build

There were 1 spelling errors.
Check the build link above for details.

allyhawkins
allyhawkins reviewed Apr 18, 2024
View reviewed changes
Copy link
Member

@allyhawkins allyhawkins left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The caption for Table 1 in the methods is showing up on the bottom of the page and then there's a new page for the actual table. Are we okay with that? Other than that this looks fine to me.

allyhawkins
allyhawkins approved these changes Apr 18, 2024
View reviewed changes
Copy link
Member

@allyhawkins allyhawkins left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@github-actions GitHub Actions
Copy link

Click the link below to download the manuscript build as a ZIP file.
This build is associated with commit 668cd5c.

Manuscript build

There were 1 spelling errors.
Check the build link above for details.

@jaclyn-taroni jaclyn-taroni merged commit 01d2a7c into main Apr 18, 2024
1 check passed
@jaclyn-taroni jaclyn-taroni deleted the jaclyn-taroni/resize-figures-for-biorxiv branch April 18, 2024 18:55
github-actions bot pushed a commit that referenced this pull request Apr 18, 2024
@jaclyn-taroni
Merge pull request #120 from AlexsLemonade/jaclyn-taroni/resize-figur…
76be13b 
…es-for-biorxiv

[ci skip]

This build is based on
01d2a7c.

This commit was created by the following CI build and job:
https://github.com/AlexsLemonade/ScPCA-manuscript/commit/01d2a7c47d299ec426da06a063238aeee33f5f0f/checks
https://github.com/AlexsLemonade/ScPCA-manuscript/actions/runs/8743224573
github-actions bot pushed a commit that referenced this pull request Apr 18, 2024
@jaclyn-taroni
Merge pull request #120 from AlexsLemonade/jaclyn-taroni/resize-figur…
4c14f74 
…es-for-biorxiv

[ci skip]

This build is based on
01d2a7c.

This commit was created by the following CI build and job:
https://github.com/AlexsLemonade/ScPCA-manuscript/commit/01d2a7c47d299ec426da06a063238aeee33f5f0f/checks
https://github.com/AlexsLemonade/ScPCA-manuscript/actions/runs/8743224573
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@allyhawkins allyhawkins allyhawkins approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@jaclyn-taroni @allyhawkins