Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update diagnosis and disease timing numbers #133

Merged
merged 3 commits into from
Jan 14, 2025

Conversation

allyhawkins
Copy link
Member

Closes #124

Here I'm just updating the text to have the updated numbers for diagnoses and disease timing. The updated numbers are from the tables in scpca-paper-figures.

I also found a spot in the legend that needed to be updated based on the new numbers.

Copy link

Click the link below to download the manuscript build as a ZIP file.
This build is associated with commit da9f406.

Manuscript build

There were 1 spelling errors.
Check the build link above for details.

@allyhawkins
Copy link
Member Author

Note that there was an error with mamba in CI, so there were a few other small changes here. I mimicked what was done in manubot/rootstock#520.

jaclyn-taroni
jaclyn-taroni previously approved these changes Jan 14, 2025
Copy link
Member

@jaclyn-taroni jaclyn-taroni left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@jaclyn-taroni jaclyn-taroni dismissed their stale review January 14, 2025 13:42

Cell line numbers

The largest number of samples found on the Portal were obtained from patients with leukemia (n = 216).
The Portal also includes samples from sarcoma and soft tissue tumors (n = 194), brain and central nervous system tumors (n = 167), and a variety of other solid tumors (n = 117).
Most samples were collected at initial diagnosis (n = 521), with a smaller number of samples collected either at recurrence (n = 129), during progressive disease (n = 13), during or after treatment (n = 11), or post-mortem (n = 5).
Along with the patient tumors, the Portal contains a small number of human tumor cell line samples (n = 6).
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

So, only the 4 NB cell lines are marked as cell lines on the Portal. The PDX lines (https://scpca.alexslemonade.org/projects/SCPCP000024) are marked as PDX. I see your point here, but we should either be consistent with the Portal or perhaps set is_cell_line and is_xenograft both to TRUE.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ah okay I was confused about this because I thought we had 6 cell lines, but then when I looked at the portal there was only 4 and then I filtered our sample metadata by is_cell_line and only saw 4. I think that they should both be set to true.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

If you're good with that, then I'll file an issue to update that in ScPCA-admin and group that with the other metadata changes for hand off and then update the number here to 6.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yea, that's fine. In practice, we should bundle updating this with the other data release 🎟️

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You said that already. I missed it.

Copy link
Member

@jaclyn-taroni jaclyn-taroni left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Going to approve again with the expectation of the issue of the cell line number getting tracked and resolved another way.

@allyhawkins allyhawkins merged commit 6c5de76 into main Jan 14, 2025
1 check passed
@allyhawkins allyhawkins deleted the allyhawkins/diagnosis-disease-timing-number-update branch January 14, 2025 15:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Update numbers for diagnosis and modality breakdown
2 participants