-
Notifications
You must be signed in to change notification settings - Fork 1
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Adding my edits to introduction #22
Adding my edits to introduction #22
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Honestly, I don't have very many additional comments on the changes that you made here. Most of it just seems to be some rewording and it sounds a lot better. I agree with moving up that one sentence., so I can go ahead and do that and then we can get this merged in to my branch unless you have other things you wanted me to look at here?
content/02.introduction.md
Outdated
To ensure that all current and future data on the Portal are uniformly processed, we created scpca-nf, a Nextflow-based open-source pipeline (https://github.com/AlexsLemonade/scpca-nf). | ||
The scpca-nf workflow uses alevin-fry for fast and efficient quantification of gene expression for all samples on the Portal, including single-cell RNA-seq data and any associated ADT/CITE-seq or cell hash data, spatial transcriptomics data, and bulk RNA-seq data. | ||
<!-- TODO: Move uniformly processed value-add explanation up to previous paragraph? --> | ||
Ensuring all data on the Portal are uniformly processed allows users to perform analysis across multiple samples and projects without having to do any re-processing. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
If the comments you have here mean you want to move this sentence to where you have the above comment, I'm good with that. I think it makes sense.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
So my journey with 54ca43e was that I moved the sentence, reworded it, and then decided I wanted to put the reworded sentence back where it was 🎢
If you agree with all the changes here, feel free to merge @allyhawkins and then I'll approve #18 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Reworded sentence looks good where it is 👍
Stacked on #18. @allyhawkins, we might want to briefly touch base about the best way to incorporate these edits; I don't necessarily expect you to accept them wholesale and merge this in.
The content is largely the same, in my opinion. This is mostly cutting words and rearranging a bit. You will notice I use HTML comments to indicate a question about where we should discuss the benefits of uniformly processed data.