Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add captions for figures 3 & 4 #51

Merged
merged 9 commits into from
Feb 28, 2024
Merged

Conversation

sjspielman
Copy link
Member

Closes #12
Closes #13
Stacked on #36

This PR adds the caption (I seem to always call it legend but I never mean legend...) for figures 3-4.

Base automatically changed from sjspielman/11-fig2-legend to main February 27, 2024 17:59
Copy link
Member

@allyhawkins allyhawkins left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just a few comments. We should figure out how we are dealing with SCE abbreviations. I haven't been using them in the text, but I can use them so that readers are familiar with the term. That being said, I think we should still do what you have in Figure 2 where you have the full name and abbreviation the first time you mention SCEs.


![**Figure 3. ScPCA Portal project download file structure and merged object workflow.**](https://raw.githubusercontent.com/AlexsLemonade/scpca-paper-figures/main/figures/compiled_figures/pngs/figure_3.png?sanitize=true){#fig:fig3 width="7in"}

A. File download structure for an ScPCA Portal project download in `SCE` format.
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
A. File download structure for an ScPCA Portal project download in `SCE` format.
A. File download structure for an ScPCA Portal project download in `SingleCellExperiment` format.

Generally I haven't been abbreviating this in the text so I think for the legends we could use the full name too. I know I already approved a legend with the abbreviation, but I think we should pick one approach and match the text.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I now realize that we are using SCE in the figures themselves. Can we just be sure to have SingleCellExperiment(SCE) in each of the legends?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

For the fig 4 legend, it didn't seem like there was really a place for this. The only time I use SCE is to refer to literal items in the workflow figure. Do you still think we need it?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

fyi the line above is now "SingleCellExperiment (SCE)"

content/100.figure-table-legends.md Outdated Show resolved Hide resolved
content/100.figure-table-legends.md Outdated Show resolved Hide resolved
content/100.figure-table-legends.md Outdated Show resolved Hide resolved
Copy link

Click the link below to download the manuscript build as a ZIP file.
This build is associated with commit d10700b.

Manuscript build

Copy link

Click the link below to download the manuscript build as a ZIP file.
This build is associated with commit a0f8f73.

Manuscript build

Copy link

Click the link below to download the manuscript build as a ZIP file.
This build is associated with commit 0667fdf.

Manuscript build

Copy link
Member

@allyhawkins allyhawkins left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good!

![**Figure 4. Cell type annotation in `scpca-nf`.**](https://raw.githubusercontent.com/AlexsLemonade/scpca-paper-figures/main/figures/compiled_figures/pngs/figure_4.png?sanitize=true){#fig:fig4 width="7in"}

A. Expanded view of the process for adding cell type annotations within `scpca-nf`, as introduced in Figure 2A.
Cell type annotation is performed on the `Processed SCE Object`.
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Because you use the icon labels like this to describe all the objects throughout the figure legends I think you can leave it.

Copy link

Click the link below to download the manuscript build as a ZIP file.
This build is associated with commit 7215c54.

Manuscript build

Copy link

Click the link below to download the manuscript build as a ZIP file.
This build is associated with commit bc2e28f.

Manuscript build

@sjspielman sjspielman merged commit 9eed2cb into main Feb 28, 2024
1 check passed
@sjspielman sjspielman deleted the sjspielman/fig3-fig4-caption branch February 28, 2024 17:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Figure legends: Fig 4 Figure legends: Fig 3
2 participants