Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Draft edits #93

Merged
merged 12 commits into from
Mar 20, 2024
Merged

Draft edits #93

merged 12 commits into from
Mar 20, 2024

Conversation

sjspielman
Copy link
Member

This PR contains my draft edits.

Copy link

Click the link below to download the manuscript build as a ZIP file.
This build is associated with commit de285cb.

Manuscript build

Copy link

Click the link below to download the manuscript build as a ZIP file.
This build is associated with commit 1746159.

Manuscript build

Copy link

Click the link below to download the manuscript build as a ZIP file.
This build is associated with commit e4a96fa.

Manuscript build

Copy link

Click the link below to download the manuscript build as a ZIP file.
This build is associated with commit d418140.

Manuscript build

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

the spacing changes here are to make sure the figure titles and references render properly. they are all working now!

@sjspielman sjspielman requested a review from allyhawkins March 19, 2024 20:22
@sjspielman sjspielman marked this pull request as ready for review March 19, 2024 20:22
Copy link

Click the link below to download the manuscript build as a ZIP file.
This build is associated with commit 60f5361.

Manuscript build

Submitted metadata was mapped to an associated ontology term identifiers obtained from HsapDV (age) [@url:https://www.ebi.ac.uk/ols4/ontologies/hsapdv], PATO (sex) [@url:https://www.ebi.ac.uk/ols4/ontologies/pato], NCBI taxonomy (organism) [@url:https://www.ncbi.nlm.nih.gov/taxonomy], MONDO (disease) [@url:https://www.ebi.ac.uk/ols4/ontologies/mondo], UBERON (tissue) [@url:https://www.ebi.ac.uk/ols4/ontologies/uberon], and Hancestro (ethnicity, if applicable) [@url:https://www.ebi.ac.uk/ols4/ontologies/hancestro].
Including ontology term identifiers for each sample provides users with standardized metadata terms that can be used across all projects.
Submitted metadata was mapped to an associated ontology term identifiers obtained from HsapDV (age) [@url:https://www.ebi.ac.uk/ols4/ontologies/hsapdv], PATO (sex) [@url:https://www.ebi.ac.uk/ols4/ontologies/pato], NCBI taxonomy (organism) [@url:https://www.ncbi.nlm.nih.gov/taxonomy], MONDO (disease) [@url:https://www.ebi.ac.uk/ols4/ontologies/mondo], UBERON (tissue) [@url:https://www.ebi.ac.uk/ols4/ontologies/uberon], and Hancestro (ethnicity, if applicable) [@url:https://www.ebi.ac.uk/ols4/ontologies/hancestro].
With these ontology term identifiers for each sample provides, users have access to standardized metadata terms that facilitate comparing datasets to one another within the Portal as well as to data from other research projects.
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

FYI about this change - I was confused by what we meant by "all projects," so I rephrased a bit. Did I overly change the meaning?

Copy link
Member

@allyhawkins allyhawkins left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, just a few suggestions.

content/03.results.md Outdated Show resolved Hide resolved
content/03.results.md Outdated Show resolved Hide resolved
Copy link

Click the link below to download the manuscript build as a ZIP file.
This build is associated with commit d336640.

Manuscript build

@sjspielman sjspielman merged commit 0483087 into main Mar 20, 2024
1 check passed
@sjspielman sjspielman deleted the sjspielman/round-robin-edits branch March 20, 2024 12:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants