Add rowData to summed SCE output #20
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
updates: - [github.com/crate-ci/typos: v1.28.2 → v1.28.3](crate-ci/typos@v1.28.2...v1.28.3)
…o jashapiro/sum-rownames
Noting also this seems reasonable to me, and the updated docs explain clearly what is done, so 👍 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I realized in testing that we had lost the rowData when summing SCE objects over duplicated features, so this PR adds those back.
I am currently using just the first row encountered in the case of duplicates, which I think is fine for most cases, as it will keep things consistent. I just had a thought that we could instead use the id with the greatest expression, but that could results in different translations for different objects, which seemed not so great. So I left it as just the first. I also considered concatenation, but that seemed too messy, again for little gain.
Following #19, I also added
devtoolstorenvhere for developer convenience. I also added a few updates to pre-commit so it doesn't bother us with update PRs so often.