-
-
Notifications
You must be signed in to change notification settings - Fork 0
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
318 - Add GA custom event for Email Subscription to DOM elements #325
Merged
nozomione
merged 274 commits into
dev
from
nozomione/318-add-ga4-custom-event-for-email-subscription
Sep 16, 2024
Merged
318 - Add GA custom event for Email Subscription to DOM elements #325
nozomione
merged 274 commits into
dev
from
nozomione/318-add-ga4-custom-event-for-email-subscription
Sep 16, 2024
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…t codebase accordingly
…or/*, and make its index to be the Error parent component and use it to render its custom error child components in _error
…r the search results page error
…page' into nozomione/261-fix-clear-term-button-on-search-box
… nozomione/262-fix-typo-in-rna-seq-sample-compendia
…o nozomione/249-align-show-label-in-experiments-view-tab
… into nozomione/267-add-word-break-to-platform-names-in-search-card
…h-card' into nozomione/220-error-handling-for-samples-table-resource-fetching
…-fetching' into nozomione/271-error-handling-for-search-results-page
…rch compopent based on the changes
…nto nozomione/170-implement-error-handling-for-compendia-page
…late, and specify a single coulmn styles for elements in Custom504
…nto nozomione/170-implement-error-handling-for-compendia-page
…of 'Rna-seq' for facet's technology
…e-resource-fetching
…dal for some experiments
…ge' into nozomione/279-fomat-rna-seq-name-in-ui-for-technology
…nto nozomione/170-implement-error-handling-for-compendia-page
…-fetching' into nozomione/271-error-handling-for-search-results-page
…nozomione/317-add-ga4-custom-event-for-search
…the custom script updates
…omione/318-add-ga4-custom-event-for-email-subscription
…n the custom script updates
…n (remove usePageRendered hook , no longer used)
…zomione/316-add-ga4-custom-event-for-compendia
…nozomione/317-add-ga4-custom-event-for-search
…omione/318-add-ga4-custom-event-for-email-subscription
…zomione/316-add-ga4-custom-event-for-compendia
…nozomione/317-add-ga4-custom-event-for-search
…omione/318-add-ga4-custom-event-for-email-subscription
This PR is ready for your review, thank you David! |
davidsmejia
approved these changes
Sep 11, 2024
…lean up unused labels and a comment, and dataset ID checks
…zomione/316-add-ga4-custom-event-for-compendia
…tedOrganismName from analytics/helpers
…nozomione/317-add-ga4-custom-event-for-search
…rackSearchTermFromQuery (previously trackSearchTerm) and trackFilterCombinationFromQuery (previously trackFilterCombinatin) - rename these methods to distinguish them from other Search methods and make it clear that they are called from trackSearchQuery
…omione/318-add-ga4-custom-event-for-email-subscription
Base automatically changed from
nozomione/317-add-ga4-custom-event-for-search
to
dev
September 16, 2024 23:04
This PR was approved on 9/11, so I am going to merge it, thank you! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue Number
Closing #318
Purpose/Implementation Notes
development
environmentTo see the email subscription custom GA4 reports, please login to CCDL Analytics account, and navigate to the
development
propertyRefine.bio Web - Dev
(issue #310).Types of changes
Checklist