Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

318 - Add GA custom event for Email Subscription to DOM elements #325

Merged
merged 274 commits into from
Sep 16, 2024

Conversation

nozomione
Copy link
Member

@nozomione nozomione commented Jan 22, 2024

Issue Number

Closing #318

Purpose/Implementation Notes

  • Add custom events for email subscription to DOM elements using the GA custom events script
  • Verified that custom events are firing correctly in the development environment

To see the email subscription custom GA4 reports, please login to CCDL Analytics account, and navigate to the development property Refine.bio Web - Dev (issue #310).

Types of changes

  • New feature (non-breaking change which adds functionality)

Checklist

  • Lint and unit tests pass locally with my changes
  • I have added tests that prove my fix is effective or that my feature works
  • I have added necessary documentation (if appropriate)
  • Any dependent changes have been merged and published in downstream modules

…or/*, and make its index to be the Error parent component and use it to render its custom error child components in _error
…page' into nozomione/261-fix-clear-term-button-on-search-box
… nozomione/262-fix-typo-in-rna-seq-sample-compendia
…o nozomione/249-align-show-label-in-experiments-view-tab
… into nozomione/267-add-word-break-to-platform-names-in-search-card
…h-card' into nozomione/220-error-handling-for-samples-table-resource-fetching
…-fetching' into nozomione/271-error-handling-for-search-results-page
…nto nozomione/170-implement-error-handling-for-compendia-page
…late, and specify a single coulmn styles for elements in Custom504
…nto nozomione/170-implement-error-handling-for-compendia-page
…ge' into nozomione/279-fomat-rna-seq-name-in-ui-for-technology
…nto nozomione/170-implement-error-handling-for-compendia-page
…-fetching' into nozomione/271-error-handling-for-search-results-page
@nozomione
Copy link
Member Author

This PR is ready for your review, thank you David!

…lean up unused labels and a comment, and dataset ID checks
…zomione/316-add-ga4-custom-event-for-compendia
…nozomione/317-add-ga4-custom-event-for-search
…rackSearchTermFromQuery (previously trackSearchTerm) and trackFilterCombinationFromQuery (previously trackFilterCombinatin) - rename these methods to distinguish them from other Search methods and make it clear that they are called from trackSearchQuery
…omione/318-add-ga4-custom-event-for-email-subscription
Base automatically changed from nozomione/317-add-ga4-custom-event-for-search to dev September 16, 2024 23:04
@nozomione
Copy link
Member Author

This PR was approved on 9/11, so I am going to merge it, thank you!

@nozomione nozomione merged commit 20e4426 into dev Sep 16, 2024
2 checks passed
@nozomione nozomione deleted the nozomione/318-add-ga4-custom-event-for-email-subscription branch September 16, 2024 23:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add GA custom event for Email Subscription to DOM elements
2 participants