1025 - Add test_dispatch_to_batch #1042
Conversation
…ction adding sample library relation
There was a problem hiding this comment.
I think the test_project_id_submission exposes opaqueness in how dispatch_to_batch handles existing computed files.
I think we should add a new arguments to the command:
--recreate-all: will call submit_jobs on all project or specified project in--project-id
Also let's update the docstring on the command to indicate that the default behavior will only dispatch batch jobs for all computed files where a project has none.
api/scpca_portal/test/factories.py
Outdated
| @factory.post_generation | ||
| def add_sample_library_relation(self, create, extracted, **kwargs): | ||
| if not create: | ||
| return |
There was a problem hiding this comment.
Add a doc string that explains the many to many consideration here
| self.assertIn(sample_no_files.scpca_id, submitted_sample_ids) | ||
|
|
||
| @patch("scpca_portal.management.commands.dispatch_to_batch.Command.submit_job") | ||
| def test_all_projects_have_computed_files(self, mock_submit_job): |
There was a problem hiding this comment.
assert that computed files exist here
| mock_submit_job.assert_not_called() | ||
|
|
||
| @patch("scpca_portal.management.commands.dispatch_to_batch.Command.submit_job") | ||
| def test_project_id_submission(self, mock_submit_job): |
There was a problem hiding this comment.
| def test_project_id_submission(self, mock_submit_job): | |
| def test_project_id_argument(self, mock_submit_job): |
|
Can you also add a log to the end of the dispatch to batch command that summarizes how many jobs were sent. |
| If regenerate-all is passed, then all computed files are regenerated for all projects. | ||
| If a project-id is passed, and not combined with regenerate-all, | ||
| then computed files are only submitted for that specific project if it has no computed files. | ||
| If it is combined with regenerate-all, then computed files are regenerated regardless. |
There was a problem hiding this comment.
I think this is more concise. Optionally, you can say that options may be combined.
| If regenerate-all is passed, then all computed files are regenerated for all projects. | |
| If a project-id is passed, and not combined with regenerate-all, | |
| then computed files are only submitted for that specific project if it has no computed files. | |
| If it is combined with regenerate-all, then computed files are regenerated regardless. | |
| If regenerate-all is passed, then presence of existing computed files are ignored. | |
| If a project id is passed then all other projects will be ignored. |
| if project_id: | ||
| projects.filter(scpca_id=project_id) |
There was a problem hiding this comment.
This doenst look right to me, my understanding is that querysets are immutable. I would first try to make your tests fail with this implementation then fix this to overwrite the projects queryset.
There was a problem hiding this comment.
This was my mistake, you are correct. Addressed.
…ty without proper assignment bug
Issue Number
Closes #1025
Purpose/Implementation Notes
Add a test module for
dispatch_to_batchwhich tests correct project querying and job submission.Update
ProjectFactoryfactory method to adequately handle the library and sample relationship.Types of changes
What types of changes does your code introduce?
Functional tests
test_dispatch_to_batchtest_only_projects_without_computed_files_submittedtest_project_id_submissionChecklist
Screenshots
N/A