Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

propagate tags from aws_batch_job_definition #1057

Merged
merged 2 commits into from
Jan 23, 2025

Conversation

davidsmejia
Copy link
Contributor

Issue Number

#959

Purpose/Implementation Notes

By default custom tags are not passed from the job definition to individual jobs/tasks. This PR forces the job/task's tags to be assigned at time of creation from the job_description.

Note: propagated tags do not take priority and may be overridden at time of job/task creation.

Types of changes

  • New feature (non-breaking change which adds functionality)

Functional tests

N/A

terraform validate passed

Checklist

  • Lint and unit tests pass locally with my changes

Screenshots

N/A

@davidsmejia davidsmejia changed the title Davidsmejia/propagate tags propagate tags from aws_batch_job_definition Jan 23, 2025
Copy link
Contributor

@avrohomgottlieb avrohomgottlieb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@davidsmejia davidsmejia merged commit acc04bc into dev Jan 23, 2025
5 checks passed
@davidsmejia davidsmejia deleted the davidsmejia/propagate-tags branch January 23, 2025 19:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants