Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Include paths in output TSV #18

Merged
merged 5 commits into from
Jun 6, 2024
Merged

Conversation

sjspielman
Copy link
Member

Towards #17

This PR updates the script and dockerfile (with dependencies) to include the file path in the returned table. I think actually in the opening issue comments @jashapiro and I had the same strategy in mind, just that his was written clearly 😄 , so that's the strategy I took! Seems to be working fine when running locally on my end.

After this goes in, I'll do a 0.3 (and 0) release, and close out the issue.

@sjspielman sjspielman requested a review from jashapiro June 4, 2024 19:45
spell-check.R Outdated Show resolved Hide resolved
@sjspielman sjspielman requested a review from jashapiro June 5, 2024 22:44
@sjspielman
Copy link
Member Author

Confirming the code works!

Copy link
Member

@jashapiro jashapiro left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

spell-check.R Outdated Show resolved Hide resolved
Dockerfile Outdated Show resolved Hide resolved
@sjspielman sjspielman merged commit f293333 into main Jun 6, 2024
1 check passed
@sjspielman sjspielman deleted the sjspielman/17-include-paths branch June 6, 2024 14:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants