Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add bluster functions to cheatsheet #814

Merged
merged 5 commits into from
Dec 2, 2024

Conversation

sjspielman
Copy link
Member

@sjspielman sjspielman commented Nov 27, 2024

Closes #813

This PR adds bluster functions used in the (forthcoming) exercise notebook to the scRNA-seq-advanced.

A couple additional questions:

  • I also realized we don't have bluster in the scRNA-seq cheatsheet. Should I go ahead and add clusterRows() there too?
  • I haven't done ☝️ (yet) in case we think I should also add NNGraphParam() (and/or KGraphParam() KMeansParam() which is also used in the scRNA-seq module), so I'll do this all in one go if we want to add more!

@sjspielman sjspielman requested a review from jashapiro November 27, 2024 18:13
@sjspielman
Copy link
Member Author

Given https://github.com/AlexsLemonade/exercise-notebook-answers/pull/228/files#r1861067009, I'm thinking I should go ahead and add NNGraphParam() and KGraphParam().

@jashapiro
Copy link
Member

jashapiro commented Dec 2, 2024

Given https://github.com/AlexsLemonade/exercise-notebook-answers/pull/228/files#r1861067009, I'm thinking I should go ahead and add NNGraphParam() and KGraphParam() KMeansParam()*.

I was just about to say this. And you may as well add it to the scRNA-seq cheatsheet while you are doing this.

@sjspielman
Copy link
Member Author

@jashapiro done!

Copy link
Member

@jashapiro jashapiro left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I did a bit of rewording, and fixed a function name. See what you think of the rewords.

module-cheatsheets/scRNA-seq-advanced-cheatsheet.md Outdated Show resolved Hide resolved
module-cheatsheets/scRNA-seq-advanced-cheatsheet.md Outdated Show resolved Hide resolved
Copy link
Member

@jashapiro jashapiro left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM (Though I am baffled by the size changes for the PDFs)

@sjspielman
Copy link
Member Author

Though I am baffled by the size changes for the PDFs

Wow that is baffling...

@sjspielman sjspielman merged commit 791c392 into master Dec 2, 2024
1 check passed
@sjspielman sjspielman deleted the sjspielman/813-bluster-to-cheatsheet branch December 2, 2024 20:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add cluster evaluation functions to scRNA-seq-advanced cheatsheet
2 participants