Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add setup script and updates for wilms data #818

Merged
merged 9 commits into from
Dec 2, 2024

Conversation

sjspielman
Copy link
Member

Closes #815
Closes #816

This PR adds a download script, and makes other relevant script modifications, for the Wilms tumor (SCPCP000006) sample we are going to be using for the scRNA-seq-advanced cluster evaluation exercise. I largely followed the approach from #807 to use OpenScPCA for download assistance. The single file downloaded is saved in scRNA-seq-advanced/data/wilms-tumor/processed/SCPCS000203/SCPCL000240_processed.rds.

While I was here, I also fixed the typo as noted in #816.

@sjspielman sjspielman requested a review from jashapiro December 2, 2024 16:29
Copy link
Member

@jashapiro jashapiro left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks good overall, but I think you accidentally deleted a line in the sync script and you shouldn't need one you added.

I also suggested updating the environment variable name to better match conventions, and to support using the currently active profile more easily. We could make the same updates to the Ewings script, or just leave everything as is...

@@ -37,14 +37,14 @@ sync_dirs=(
scRNA-seq/data/tabula-muris/alevin-quant/10X_P7_12
scRNA-seq/data/reference
scRNA-seq/index/Mus_musculus
scRNA-seq-advanced/data/ewing-sarcoma/processed
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't think you meant to remove this?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copy/paste gone wrong indeed!

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@@ -63,6 +63,7 @@ sync_files=(
scRNA-seq-advanced/data/ewing-sarcoma/annotations/ewing_sarcoma_sample_metadata.tsv
scRNA-seq-advanced/data/rms/annotations/rms_sample_metadata.tsv
scRNA-seq-advanced/data/reference/hs_mitochondrial_genes.tsv
scRNA-seq-advanced/data/wilms-tumor/processed/SCPCS000203/SCPCL000240_processed.rds
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We should not need to include the individual file here. The only time this is needed is if we don't want to upload the entire folder. Nothing nested in a directory above should be needed here.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

done in 6422de7

scRNA-seq-advanced/setup/wilms-tumor/README.md Outdated Show resolved Hide resolved
scRNA-seq-advanced/setup/wilms-tumor/README.md Outdated Show resolved Hide resolved
@sjspielman sjspielman requested a review from jashapiro December 2, 2024 17:57
Copy link
Member

@jashapiro jashapiro left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, with one fix.

Just to note, I had left the internal variable as PROFILE in my suggestion to save the need for the downfile edits, but either way is fine.

@sjspielman sjspielman merged commit 6b7d155 into master Dec 2, 2024
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Fix ewings setup typo Add wilms dataset for new clustering exercise
2 participants