Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Harmony fix #827

Merged
merged 2 commits into from
Dec 6, 2024
Merged

Harmony fix #827

merged 2 commits into from
Dec 6, 2024

Conversation

sjspielman
Copy link
Member

@sjspielman sjspielman commented Dec 6, 2024

This PR bumps HarmonyMatrix() --> RunHarmony() in the instruction notebook and in the cheatsheet, to which rows were added and* bytes were removed in a continuation of things we do not understand. 🥴

Next steps:

  • Enliven notebooks
  • Redo release
  • Recopy notebooks to workshop website repo
  • Have 0 dull moments
  • Skel things

Note that I confirmed the result of these two code versions is identical, sans deprecation warnings.

@sjspielman sjspielman requested a review from jashapiro December 6, 2024 15:27
Copy link
Member

@jashapiro jashapiro left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

@sjspielman sjspielman merged commit 06967b5 into master Dec 6, 2024
2 checks passed
@sjspielman sjspielman deleted the sjspielman/harmony-code-bump branch December 6, 2024 15:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants