Fix H200 + D230 Doorbell stream #1543
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Because it discards the leftovers in the network buffer. It is pretty common practice in go to use io.Copy and then close the body of a request |
SVilgelm
reviewed
Jan 9, 2025
Co-authored-by: Sergey Vilgelm <[email protected]>
|
it would be better to refactor all such cases instead of just this one, but can be done in separate PRs |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As stated in my issue #1174 streaming the D230 doorbell was not possible.
Running firmware versions:
H200: 1.3.6 Build 20240829 rel.71119
D230: 1.1.17 Build 20240731 rel.53511
This PR is implementing the fix suggested by @aprilmaccydee (as stated in #1174 (comment)). So all credits to them for figuring that out and sharing.
Using "io.Copy" reads the full body before discarding it, while "Body.Close()" only closes the body. I am not quite sure, why that makes a difference, but it does.