Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[OGUI-1565] Display infologger link to each task in env-details #2725

Merged

Conversation

pepijndik
Copy link
Contributor

@pepijndik pepijndik commented Jan 21, 2025

The request of this ticket is to add another button (and such create a btn-group out of the two buttons). This new button should be labeled "ILG" and work in a similar fashion to existing infologgerbutton which opens infologger. But extra, it should add one more parameter, that is pid with the value of the pid of the task that it is in line with. (PID can be seen in ECS GUI table as well)

I have JIRA issue created

  • branch and/or PR name(s) includes JIRA ID
  • issue has "Fix version" assigned
  • issue "Status" is set to "In review"
  • PR labels are selected
  • FLP integration tests were ran successful

Placed it in the wrong place for the ticket, updated code to match ticket description
@graduta graduta changed the title Feature/pep/og UI 1565/displayinfologgerfilterlinksintaskstable [OGUI-1565] Display infologger link to each task in env-details Jan 29, 2025
Copy link
Contributor Author

@pepijndik pepijndik left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, no comments ;-)

@graduta graduta merged commit f83cd41 into dev Jan 29, 2025
9 checks passed
@graduta graduta deleted the feature/pep/OGUI-1565/displayinfologgerfilterlinksintaskstable branch January 29, 2025 16:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Development

Successfully merging this pull request may close these issues.

2 participants