Fix debian packaging #42
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
to bring it in line with the official Debian/Ubuntu packages
This prevents FTBFS in projects that uses libsope-ldap-dev
|
Maybe I'm wrong but how far I understand the packaging for the libsbjson is not even required because it is in the all main debian/ubuntu stable releases (from wheezy in debian and from trusty in ubuntu). |
|
Inverse branch of SBJson contains one commit that addresses crash if result is NSNull. See: 45339ab |
|
Added commit 3850f3f, which allows to build on Debian Stretch. Is there something I could have done to be able to merge the proposed changes? |
|
|
|
I accepted, but even the recheck does not pick it up :( I saw already accepted if I go again... something wrong with the integration |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Renaming libsbjson2.3-dev to libsbjson-dev resolves conflict with the official distribution package.
Adding libldap2-dev dependency solves FTBFS when building SOGo in a clean chroot environment (pbuilder). Include files in libsope-ldap-dev require the include files from libldap2-dev. Therefore I consider it right that libldap2-dev should be listed as a dependency in libsope-ldap-dev.