Skip to content

Commit

Permalink
codegen: remove typedefsNames
Browse files Browse the repository at this point in the history
this field in context was never filled
  • Loading branch information
gucio321 committed Nov 14, 2024
1 parent 51c118b commit 8a407fd
Show file tree
Hide file tree
Showing 3 changed files with 6 additions and 7 deletions.
2 changes: 1 addition & 1 deletion cmd/codegen/arguments_wrapper.go
Original file line number Diff line number Diff line change
Expand Up @@ -301,7 +301,7 @@ for i, %[1]sV := range %[1]sArg {
}

_, shouldSkipRefTypedef := context.preset.SkipTypedefs[pureType]
if context.structNames[pureType] || context.typedefsNames[pureType] || (isRefTypedef && !shouldSkipRefTypedef) {
if context.structNames[pureType] || (isRefTypedef && !shouldSkipRefTypedef) {
srcPkg := context.flags.packageName
if isRefTypedef {
srcPkg = context.flags.refPackageName
Expand Down
2 changes: 1 addition & 1 deletion cmd/codegen/gengo_funcs.go
Original file line number Diff line number Diff line change
Expand Up @@ -40,7 +40,7 @@ func GenerateGoFuncs(
) error {
generator := &goFuncsGenerator{
prefix: context.prefix,
structNames: context.typedefsNames,
structNames: context.structNames,
enumNames: context.enumNames,
refTypedefs: context.refTypedefs,
context: context,
Expand Down
9 changes: 4 additions & 5 deletions cmd/codegen/main.go
Original file line number Diff line number Diff line change
Expand Up @@ -126,10 +126,9 @@ type Context struct {
typedefs *Typedefs

// ghese fields are filled by parser while it generates code.
funcNames map[CIdentifier]bool // funcs are filled by gencpp
enumNames map[CIdentifier]bool
structNames map[CIdentifier]bool
typedefsNames map[CIdentifier]bool
funcNames map[CIdentifier]bool // funcs are filled by gencpp
enumNames map[CIdentifier]bool
structNames map[CIdentifier]bool

// contains helper C functions to get/set struct fields
// of array types
Expand Down Expand Up @@ -238,7 +237,7 @@ func main() {
glg.Fatalf("Generating enum names: %v", err)
}

context.enumNames = MergeMaps(SliceToMap(enumNames))
context.enumNames = SliceToMap(enumNames)

// 1.2. Generate Go typedefs
callbacks, err := GenerateTypedefs(context.typedefs, context.structs, context)
Expand Down

0 comments on commit 8a407fd

Please sign in to comment.