Code cleanup #374
Merged
Code cleanup #374
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
no longer needed when we have Context
also: - create helper type fr typedefs generation - rename data -> ctx (finally)
also add a type for known(ptr)Arg/Ret passing
just a few lines below is a case for void* I think this if was a leftover.
- remove commented-out debug stmt - reorder case conditions so that the most important check were on top (readability, performance)
this was missleading as it taook isOpaque argument hehe"
5 tasks
also improve logging
now GenerateXXX are public (proceedTypedefs => GenerateTypedefs
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
well, when gengo_typedefs.go has ~650 lines and the main function has 618 its deffiitly time to do something about that.
This is a first PR of planned series.
This mainly focuses on
gengo_typedefs.gofile.My goal is to achive 1 Function for generating which is +/- human-readable, and a planty of functions with not-so-guman-readable fmt.fprintf calls.