Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Feat 37 delete docdb #45

Merged
merged 4 commits into from
May 1, 2024
Merged

Feat 37 delete docdb #45

merged 4 commits into from
May 1, 2024

Conversation

mekhlakapoor
Copy link
Contributor

@mekhlakapoor mekhlakapoor commented Apr 25, 2024 •
edited
Loading

closes #37

  • deletes records from docDB if they do not exist in s3
  • now when docdb updater script is run, it'll sync docdb to s3
  • updates docstrings and the name of the s3_crawler class to be more informative

@mekhlakapoor mekhlakapoor merged commit a7d8cb9 into main May 1, 2024
3 checks passed
@mekhlakapoor mekhlakapoor deleted the feat-37-delete-docdb branch May 1, 2024 18:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@yosefmaru yosefmaru yosefmaru approved these changes

@jtyoung84 jtyoung84 Awaiting requested review from jtyoung84

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Delete records from docDB if not in s3
2 participants
@mekhlakapoor @yosefmaru