Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Codes for SUPPORT page #731

Merged
merged 8 commits into from
Jan 24, 2025
Merged

Codes for SUPPORT page #731

merged 8 commits into from
Jan 24, 2025

Conversation

shakhawatw3p
Copy link
Contributor

No description provided.

@shakhawatw3p
Copy link
Contributor Author

I have added final files for Support page.

@shakhawatw3p shakhawatw3p changed the title Adding setup page codes Codes for SUPPORT page Jan 11, 2025
@bennyvasquez bennyvasquez self-assigned this Jan 13, 2025
@bennyvasquez
Copy link
Member

Hi @shakhawatw3p! Thanks so much for this submission and welcome to the project! I'll get to a more detailed review this week, but at a glance the first thing I noticed is that you've got a lot of page-specific CSS built into that page, rather than using bootstrap classes. Using CSS that way then requires that you (as you saw) define reactive CSS as well, and we'd like to avoid that. Can you please adjust the places that you've used page-specific CSS to instead use bootstrap classes?

For example, where you use al-get-sup-header to define these:

  .al-get-sup-header {
    margin-bottom: 40px;
  }
  .al-get-sup-header h2 {
    font-size: 46px;
    font-weight: 700;
    margin-bottom: 26px;
  }
  .al-get-sup-header p {
    font-size: 20px;
    line-height: 27px;
    margin-bottom: 20px;
  }

Please instead use the theme's default h2 and p settings, and use the bootstrap spacing classes to set margins (mb-1 for example). Thanks so much for your efforts here!

@shakhawatw3p
Copy link
Contributor Author

Hi @bennyvasquez
Thank you so much for reviewing my codes. I've reduced CSS by using bootstrap classes. Still you can see a few page specific CSS, because we have background colors etc which is not available in BS classes. So I have reduced as I could. Please let me know if you need any more changes.
Thanks again

@bennyvasquez
Copy link
Member

bennyvasquez commented Jan 23, 2025

@shakhawatw3p I think it's a limitation of my knowledge of git, but I can't seem to check out your branch locally, which would allow me to submit a PR to it to adjust some design elements and phrasing. It seems like it's because your branch name is master, but no matter.

I've submited a PR against your repo so that you can still get credit for the work you put in. I'm not a git master, but I think if you accept my PR, then this one should get updated with the new content as well.

found the error in my conflict resolution. :D
Copy link
Member

@bennyvasquez bennyvasquez left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, @shakhawatw3p! This one is ready to go now. Have a good vacation!

@bennyvasquez bennyvasquez merged commit 5ec4180 into AlmaLinux:master Jan 24, 2025
2 checks passed
@shakhawatw3p
Copy link
Contributor Author

Hi
@bennyvasquez
Thank you so much!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants