-
Notifications
You must be signed in to change notification settings - Fork 53
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Codes for SUPPORT page #731
Conversation
I have added final files for Support page. |
Hi @shakhawatw3p! Thanks so much for this submission and welcome to the project! I'll get to a more detailed review this week, but at a glance the first thing I noticed is that you've got a lot of page-specific CSS built into that page, rather than using bootstrap classes. Using CSS that way then requires that you (as you saw) define reactive CSS as well, and we'd like to avoid that. Can you please adjust the places that you've used page-specific CSS to instead use bootstrap classes? For example, where you use al-get-sup-header to define these:
Please instead use the theme's default |
Hi @bennyvasquez |
@shakhawatw3p I think it's a limitation of my knowledge of git, but I can't seem to check out your branch locally, which would allow me to submit a PR to it to adjust some design elements and phrasing. It seems like it's because your branch name is master, but no matter. I've submited a PR against your repo so that you can still get credit for the work you put in. I'm not a git master, but I think if you accept my PR, then this one should get updated with the new content as well. |
Adjustments
found the error in my conflict resolution. :D
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks, @shakhawatw3p! This one is ready to go now. Have a good vacation!
Hi |
No description provided.