Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: Mobile App navigation #369

Merged
merged 9 commits into from
Mar 28, 2024
Merged

fix: Mobile App navigation #369

merged 9 commits into from
Mar 28, 2024

Conversation

elcharitas
Copy link
Member

This PR contains a minor UI change to portfolio tab.
Screenshot 2024-03-28 at 04 55 05

@elcharitas elcharitas marked this pull request as ready for review March 28, 2024 04:24
v-almonacid
v-almonacid approved these changes Mar 28, 2024
View reviewed changes
Copy link
Contributor

@v-almonacid v-almonacid left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great job 👍

packages/frontend/src/api/hooks/useHistory.ts Show resolved Hide resolved
packages/frontend/src/mobile-pages/portfolio.tsx Outdated Show resolved Hide resolved
packages/frontend/src/api/hooks/useHistory.ts Outdated Show resolved Hide resolved
Xavier-Charles
Xavier-Charles reviewed Mar 28, 2024
View reviewed changes
Copy link
Contributor

@Xavier-Charles Xavier-Charles left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code looks good, However when I select portfolio, it keeps redirecting to /superfeed or am I missing something.

@v-almonacid
Copy link
Contributor

Code looks good, However when I select portfolio, it keeps redirecting to /superfeed or am I missing something.

@Xavier-Charles make sure you delete cookies when you run this branch. And let us know if that doesn't work

@elcharitas elcharitas marked this pull request as draft March 28, 2024 17:11
@elcharitas elcharitas marked this pull request as ready for review March 28, 2024 17:11
@v-almonacid v-almonacid merged commit 43334b3 into dev Mar 28, 2024
4 checks passed
@v-almonacid v-almonacid deleted the fix/routing_imp branch March 28, 2024 18:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Xavier-Charles Xavier-Charles Xavier-Charles approved these changes

@v-almonacid v-almonacid v-almonacid approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@elcharitas @v-almonacid @Xavier-Charles