feat: migrate routes to modals #402
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
elcharitas
commented
Apr 17, 2024
v-almonacid
reviewed
Apr 17, 2024
|
Did you notice any improvement with this approach? |
Xavier-Charles
approved these changes
Apr 18, 2024
There was a problem hiding this comment.
This works generally but I fear it might mask the problem. If the issue for migration is solved in #405. Then it's better to pend this.
@Xavier-Charles regardless on whether this fixes anything, it's the recommended way to handle non-linear routing, so it's needed anyway. |
v-almonacid
approved these changes
Apr 18, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR does not attempt to change the current UI. It only fixes implementation details.