Eslint: don't allow var (GoogleChrome#856)

An-Yay · Mar 20, 2023 · d0dd2c3 · d0dd2c3
1 parent ad857a2
commit d0dd2c3
Show file tree

Hide file tree

Showing 3 changed files with 5 additions and 2 deletions.
diff --git a/.eslintrc.js b/.eslintrc.js
@@ -4,6 +4,7 @@ module.exports = {
   plugins: ['prettier'],
   rules: {
     'prettier/prettier': ['error'],
+    'no-var': ['error'],
     'no-unused-vars': [
       'warn',
       {

diff --git a/api-samples/printing/printers.js b/api-samples/printing/printers.js
@@ -3,7 +3,7 @@
 // found in the LICENSE file.
 
 function onPrintButtonClicked(printerId, dpi) {
-  var ticket = {
+  let ticket = {
     version: '1.0',
     print: {
       color: { type: 'STANDARD_MONOCHROME' },

diff --git a/functional-samples/sample.bookmarks/popup.js b/functional-samples/sample.bookmarks/popup.js
@@ -29,6 +29,7 @@ function dumpTreeNodes(bookmarkNodes, query) {
 }
 
 function dumpNode(bookmarkNode, query) {
+  let span = '';
   if (bookmarkNode.title) {
     if (query && !bookmarkNode.children) {
       if (
@@ -51,7 +52,7 @@ function dumpNode(bookmarkNode, query) {
       chrome.tabs.create({ url: bookmarkNode.url });
     });
 
-    var span = $('<span>');
+    span = $('<span>');
     const options = bookmarkNode.children
       ? $('<span>[<a href="#" id="addlink">Add</a>]</span>')
       : $(
@@ -182,6 +183,7 @@ function dumpNode(bookmarkNode, query) {
   }
 
   const li = $(bookmarkNode.title ? '<li>' : '<div>').append(span);
+
   if (bookmarkNode.children && bookmarkNode.children.length > 0) {
     li.append(dumpTreeNodes(bookmarkNode.children, query));
   }