Fix for #258 Variable replacement doesn't work when file is injected in multipart/form-data request #622
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…jected in multipart/form-data request
|
Did you test it manually? I got no unit test fornthis use case at the moment |
|
The fix already works as you created it. Unfortunately, it's not quite enough. In the transformRequestBodyToBuffer I have unfortunately executed two tasks at the same time. On the one hand I load files into memory and on the other hand I transform the body either into a buffer or string. You have to separate them and execute one part before and one part after the variable replacement. I merge your branch and fix it in my branch. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
AnWeber/vscode-httpyac#258