Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Added the 'Get the app ' section #41

Closed
wants to merge 0 commits into from
Closed

Added the 'Get the app ' section #41

wants to merge 0 commits into from

Conversation

StephenStolk
Copy link
Contributor

Added the 'Get your idea transformed into the app ' section

@vercel
Copy link

vercel bot commented Oct 24, 2023 •
edited
Loading

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
ac-website-next-js ✅ Ready (Inspect) Visit Preview 💬 Add feedback Oct 24, 2023 7:20pm

@shubhamm69
Copy link
Contributor

@StephenStolk

  1. Code Formatting:
    Before pushing any commits, please run npm run format to ensure consistent code formatting. This will make it easier for us to review your code. Even if you've added only 2 new files, it appears as if there are 19 file changes due to formatting.

  2. Input Border Color on Focus:
    When the form input is in focus, the border color should change to the primary color. You can refer to this link for guidance: Form State Documentation.

  3. Add Input Placeholders:
    Make sure to include input placeholders, they are missing.
    Screenshot 2023-10-25 at 2 36 35 PM

  4. Button Padding:
    Add proper padding to the top of the GET IT DONE button.

  5. Use Uppercase Font:
    Based on our design guidelines, make sure that all text in the project uses uppercase font throughout.

  6. Component Naming:
    Please follow a consistent naming scheme for components. For example, change /components/Idea_Section/ to something like components/ContactUs or components/Contact for simplicity.

  7. Separate Text Section Component:
    It's a good practice to create a separate component for the text section, similar to what you've done for the form section.

  8. Responsiveness:
    Ensure that the section is responsive. For mobile view, consider hiding the text section and centering the form.

  9. Text Section Component Design Fix:
    Once you have your component done, follow the design and instead of buttons add the text as seen in the reference image provided. You can refer to this image for guidance:
    Screenshot 2023-10-25 at 2 35 16 PM

shubhamm69
shubhamm69 reviewed Oct 25, 2023
View reviewed changes
components/Idea_Section/FormSection.tsx Outdated
<div className="flex flex-col md:flex-col md:space-x-1">
<div className="w-3/4">
<label htmlFor="name" className="block text-2xl font-medium">
Name:
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

change to uppercase

shubhamm69
shubhamm69 reviewed Oct 25, 2023
View reviewed changes
components/Idea_Section/FormSection.tsx Outdated
</div>
<div className="w-3/4 mt-4">
<label htmlFor="email" className="block text-2xl font-medium space-y-8">
Email:
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

same as above change to uppercase

shubhamm69
shubhamm69 reviewed Oct 25, 2023
View reviewed changes
components/Idea_Section/FormSection.tsx Outdated
</div>
<div className="w-3/4 mt-4">
<label htmlFor="phone" className="block text-2xl font-medium">
Mobile Number:
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

same as above change to uppercase

shubhamm69
shubhamm69 reviewed Oct 25, 2023
View reviewed changes
components/Idea_Section/FormSection.tsx Outdated
</div>
<div className="mt-4">
<label htmlFor="projectDetails" className="block text-2xl font-medium">
Project Details:
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

same as above change to uppercase

shubhamm69
shubhamm69 reviewed Oct 25, 2023
View reviewed changes
components/Idea_Section/FormSection.tsx Outdated
</div>
<div className="mt-4">
<label htmlFor="budget" className="block text-2xl font-medium">
Approximate Budget:
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

same as above change to uppercase

shubhamm69
shubhamm69 reviewed Oct 25, 2023
View reviewed changes
app/(Home)/Section5.tsx Outdated
</h1>
<section className="flex flex-col sm:flex-col md:flex-col lg:flex-row justify-around mb-32" id="Section_8">
<div className="w-full lg:w-1/2">
<section className="p-6 w-full md:p-24" id="#Section_1">
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

<section className="p-6 w-full md:p-24" id="#Section_1"> this isn't section 1, fix.

shubhamm69
shubhamm69 reviewed Oct 25, 2023
View reviewed changes
app/(Home)/Section5.tsx Outdated
Comment on lines 21 to 25
<div className="mt-6 flex animate-slideleftT3 items-center text-xl gap-16">
<Link href="#Section_4">
<button> UPCOMING EVENTS </button>
</Link>
<Link href="#Section_2">LEARN MORE </Link>
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

remove these buttons,

shubhamm69
shubhamm69 reviewed Oct 25, 2023
View reviewed changes
app/(Home)/Section5.tsx Outdated
</h1>
<section className="flex flex-col sm:flex-col md:flex-col lg:flex-row justify-around mb-32" id="Section_8">
<div className="w-full lg:w-1/2">
<section className="p-6 w-full md:p-24" id="#Section_1">
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

make component for this text section

shubhamm69
shubhamm69 requested changes Oct 25, 2023
View reviewed changes
Copy link
Contributor

@shubhamm69 shubhamm69 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please do the required changes, feel free to contact any of us.

@shubhamm69 shubhamm69 linked an issue Oct 25, 2023 that may be closed by this pull request
Contact section #12
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@shubhamm69 shubhamm69 shubhamm69 requested changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Contact section
2 participants
@StephenStolk @shubhamm69