[meta data] Persist the meta data openness state, and do something se…

…nsible while switching patches.

The-Orm/CurrentPatchDisplay.cpp

@@ -19,6 +19,8 @@
 
 #include "LayeredPatchCapability.h"
 
+#include "Settings.h"
+
 #include <boost/format.hpp>
 
 MetaDataArea::MetaDataArea(std::vector<CategoryButtons::Category> categories, std::function<void(CategoryButtons::Category)> categoryUpdateHandler) :
@@ -66,6 +68,7 @@ CurrentPatchDisplay::CurrentPatchDisplay(midikraft::PatchDatabase &database, std
 			onCurrentPatchClicked(currentPatch_);
 		}
 	})
+	, propertyEditor_(true)
 	, favorite_("Fav!")
 	, hide_("Hide")
 	, metaData_(categories, [this](CategoryButtons::Category categoryClicked) {
@@ -89,17 +92,25 @@ CurrentPatchDisplay::CurrentPatchDisplay(midikraft::PatchDatabase &database, std
 	addAndMakeVisible(metaDataScroller_);
 	addAndMakeVisible(patchAsText_);
 
+	if (Settings::instance().keyIsSet("MetaDataLayout")) {
+		lastOpenState_ = Settings::instance().get("MetaDataLayout");
+	}
+
 	// We need to recolor in case the categories are changed
 	UIModel::instance()->categoriesChanged.addChangeListener(this);
 }
 
 CurrentPatchDisplay::~CurrentPatchDisplay()
 {
 	UIModel::instance()->categoriesChanged.removeChangeListener(this);
+	Settings::instance().set("MetaDataLayout", propertyEditor_.getLayout().toStdString());
 }
 
 void CurrentPatchDisplay::setCurrentPatch(std::shared_ptr<midikraft::PatchHolder> patch)
 {
+	if (lastOpenState_.isEmpty()) {
+		lastOpenState_ = propertyEditor_.getLayout();
+	}
 	currentPatch_ = patch;
 	if (patch && patch->patch()) {
 		name_.setButtonData(patch->name(), patch->createDragInfoString());
@@ -123,6 +134,12 @@ void CurrentPatchDisplay::setCurrentPatch(std::shared_ptr<midikraft::PatchHolder
 		currentPatch_ = patch; // Keep the patch anyway, even if it was empty
 		jassertfalse;
 	}
+
+	if (lastOpenState_.isNotEmpty()) {
+		propertyEditor_.fromLayout(lastOpenState_);
+		lastOpenState_.clear();
+		resized();
+	}
 }
 
 String getTypeName(std::shared_ptr<midikraft::PatchHolder> patch)

The-Orm/CurrentPatchDisplay.h

@@ -71,6 +71,7 @@ class CurrentPatchDisplay : public Component,
 	midikraft::PatchDatabase &database_;
 	PatchButton name_;
 	PropertyEditor propertyEditor_;
+	String lastOpenState_;
 	TextButton favorite_;
 	TextButton hide_;
 	Viewport metaDataScroller_;

The-Orm/ideas.txt

@@ -3,20 +3,14 @@
 
 Bug: When you open the export to sysex dialog in an adaptation and then cancel again, KnobKraft will crash on exit.
 
-bugs:
-meta data editor needs to persist layout
-meta data editor needs to grow and shrink better (section headers don't sent data?)
-
-
-
 1.14.0:
 Mac Python warning needs to be bigger, i.e. a dialog box
 
 1.15.0 (Meta data)
 Selector for display on patch button (combo box upper right)
-better attribute entry for patch name
 * Better patch name display - the Rev2 patch names are too long. Make it two rows anyway (with two layers?). Switchable, Choice of storage place 
 * Would expect to choose sort order of patches in grid
+
 Could do better layer switch
 
 Surf! Auto-Surf! Dive!