Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Requesting Sketch for Thor for a similiar project. First Pull Request. Hope it's correct #75

Closed
wants to merge 16 commits into from

Conversation

RecycledRoadkill
Copy link

Requesting pull request for sketch for Thor for a similiar project. If I'm doing this wrong, please direct me to instructions of how to do properly.

Thank you in advance.

@AngelLM
Copy link
Owner

AngelLM commented Jun 24, 2019

Hi @RecycledRoadkill
I'm sorry but I don't understand this pull-request.
Could you please explain what you have changed?

Thanks!

@AngelLM
Copy link
Owner

AngelLM commented Jun 24, 2019

Oh, I see, sorry for not reading it carefully first.
As I read this is a pull request to merge some commits that I made in the Design Update branch into the developer branch. Is that right?
In case it is, I haven't done it yet because I have not tested the design... And as the developer branch is the most "stable" design I thought only updating it after beeing sure that the new design works...
Apart of the commits of the DesignUpdate branch, there is any other change?

@AngelLM AngelLM closed this Aug 31, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants