Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Building binary for Linux using Nuitka #94

Merged
merged 13 commits into from
Sep 7, 2023
Merged

Building binary for Linux using Nuitka #94

merged 13 commits into from
Sep 7, 2023

Conversation

ZhymabekRoman
Copy link
Contributor

Partially implements #54

@ZhymabekRoman
Copy link
Contributor Author

I just noticed that we have build.py file :(

@ZhymabekRoman ZhymabekRoman marked this pull request as draft August 29, 2023 14:01
@ZhymabekRoman ZhymabekRoman marked this pull request as ready for review September 4, 2023 10:09
@ZhymabekRoman
Copy link
Contributor Author

@Animenosekai, I am made some drafts to build binaries for Linux. So probably for now this PR is done for merge

Animenosekai
Animenosekai reviewed Sep 5, 2023
View reviewed changes
Copy link
Owner

@Animenosekai Animenosekai left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should we use build.py ?

@ZhymabekRoman
Copy link
Contributor Author

ZhymabekRoman commented Sep 5, 2023 •
edited
Loading

Well, maybe you are right. What is the point of having a build.py file?

@Animenosekai
Copy link
Owner

Animenosekai commented Sep 5, 2023 •
edited
Loading

Well, maybe you are right. What is the point of having a build.py file?

As you can see in the recent version of build.py it does way more than just building things, it helps manage the repo and helps maintaining it from a single file

@ZhymabekRoman
Copy link
Contributor Author

Done

@Animenosekai Animenosekai merged commit c352bc3 into Animenosekai:next Sep 7, 2023
@Animenosekai
Copy link
Owner

Merged 👍

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Animenosekai Animenosekai Animenosekai left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@ZhymabekRoman @Animenosekai