Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Only call stop_executor_cb once on signal #37

Merged
merged 1 commit into from
Dec 17, 2024
Merged

Only call stop_executor_cb once on signal #37

merged 1 commit into from
Dec 17, 2024

Conversation

heifner
Copy link
Member

@heifner heifner commented Dec 17, 2024

Spring AntelopeIO/spring#1074 is an instance where quit() was called during shutdown which called stop_exectur_cb which tried to access the controller after it was destroyed. Update quit() to not call stop_executor_cb() if it has already been called.

@heifner heifner merged commit 8acd515 into main Dec 17, 2024
2 checks passed
@heifner heifner deleted the call-stop-once branch December 17, 2024 20:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
OCI Work exclusive to OCI team
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants