Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Change new params in logbuyram and logsellram to binary extensions #85

Closed
wants to merge 1 commit into from

Conversation

nsjames
Copy link
Contributor

@nsjames nsjames commented May 15, 2024

Previously these params were simply added to the end of the action param list, and tests did not catch the problem because they were only using the new actions and never the old ones.

This wraps those new parameters in binary extensions so that it won't throw the assertion failure with message: datastream attempted to read past the end error.

@nsjames nsjames requested a review from DenisCarriere May 15, 2024 19:35
@nsjames
Copy link
Contributor Author

nsjames commented May 15, 2024

It seems that this is more of an issue with signers and how and when they refetch ABIs than an issue that requires binary extensions (against the original document for them that specifies that they are required for action parameter additions).

We can close this issue out with no-action as this shouldn't be an issue.

@nsjames nsjames closed this May 15, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant