feat: macOS runner support #37
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 2 commits
January 6, 2025 16:03
antazoey
changed the title
-p in mkdir cmd to avoid directory-not-exists errormkdir fails in cache-warning avoidance
antazoey
commented
Jan 8, 2025
| mkdir "${{ github.workspace }}/.build" | ||
| echo ".build directory created." | ||
| # NOTE: If /home/runner does not exist, mkdir fails. | ||
| if [ -d "$HOME" ]; then |
There was a problem hiding this comment.
ok turns out the problem is github-action never caches when using a mac runner because the name of the directory here was wrong. I am thinking changing it to $HOME variable will fix. I will know soon.
antazoey
changed the title
mkdir fails in cache-warning avoidance
antazoey
force-pushed
the
fix/mkdir-fail
branch
from
7b2e138 to
24778ac
Compare
antazoey
force-pushed
the
fix/mkdir-fail
branch
from
1d929dc to
f950f7c
Compare
antazoey
commented
Jan 8, 2025
antazoey
changed the title
added 2 commits
January 8, 2025 14:29
fubuloubu
approved these changes
Jan 8, 2025
bitwise-constructs
approved these changes
Jan 8, 2025
added 2 commits
January 9, 2025 13:07
fubuloubu
approved these changes
Jan 9, 2025
fubuloubu
approved these changes
Jan 10, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What I did
an annoying handler for repressing a warning causes the action to fail.
How I did it
use -p so that mkdir will just make all the parents if it really has to, hopefully that doesnt matter too much
How to verify it
im testing it in ape-titanoboa right now, this is blocking it from using the action which i kinda need to use for caching reasons.
Checklist