-
-
Notifications
You must be signed in to change notification settings - Fork 1.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Docs] Add timeout and fallback cheat sheets #1836
[Docs] Add timeout and fallback cheat sheets #1836
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I haven't looked at the PDFs yet as I'm on mobile right now, but are you able to provide the mark-up used to create them in some way so we could regenerate them if needed in the future? Or are the PDFs themselves editable if you have the right software (which I don't, AFAIK).
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #1836 +/- ##
=======================================
Coverage 84.59% 84.59%
=======================================
Files 308 308
Lines 6802 6802
Branches 1049 1049
=======================================
Hits 5754 5754
Misses 839 839
Partials 209 209
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
Co-authored-by: Martin Costello <[email protected]>
I've generated the pdfs from powerpoint files (added them next to the pdfs). I know, I know ... there could be better ways like latex, but I'm not familiar with that. |
I've never used LaTeX either - I just see people in academia complain about it a lot 😆 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
These are great! 👏
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
These looks great! Thanks @peter-csala
@martincostello The lower casing change did not work out well :D
I'll create a fixing PR soon. |
Pull Request
The issue or feature being addressed
Details on the issue fix or feature implementation
Confirm the following