Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Docs] Add timeout and fallback cheat sheets #1836

Merged

Conversation

peter-csala
Copy link
Contributor

Pull Request

The issue or feature being addressed

Details on the issue fix or feature implementation

Screenshot 2023-12-05 at 9 43 51

Screenshot 2023-11-22 at 20 52 49 Screenshot 2023-11-22 at 20 52 27

Confirm the following

  • I started this PR by branching from the head of the default branch
  • I have targeted the PR to merge into the default branch
  • I have included unit tests for the issue/feature
  • I have successfully run a local build

Copy link
Member

@martincostello martincostello left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I haven't looked at the PDFs yet as I'm on mobile right now, but are you able to provide the mark-up used to create them in some way so we could regenerate them if needed in the future? Or are the PDFs themselves editable if you have the right software (which I don't, AFAIK).

docs/community/cheat-sheets.md Outdated Show resolved Hide resolved
Copy link

codecov bot commented Dec 5, 2023

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (00845d7) 84.59% compared to head (3bff968) 84.59%.

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #1836   +/-   ##
=======================================
  Coverage   84.59%   84.59%           
=======================================
  Files         308      308           
  Lines        6802     6802           
  Branches     1049     1049           
=======================================
  Hits         5754     5754           
  Misses        839      839           
  Partials      209      209           
Flag Coverage Δ
linux 84.59% <ø> (ø)
macos 84.59% <ø> (ø)
windows 84.59% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@peter-csala
Copy link
Contributor Author

peter-csala commented Dec 5, 2023

I haven't looked at the PDFs yet as I'm on mobile right now, but are you able to provide the mark-up used to create them in some way so we could regenerate them if needed in the future? Or are the PDFs themselves editable if you have the right software (which I don't, AFAIK).

I've generated the pdfs from powerpoint files (added them next to the pdfs). I know, I know ... there could be better ways like latex, but I'm not familiar with that.

@martincostello
Copy link
Member

I've never used LaTeX either - I just see people in academia complain about it a lot 😆

docs/media/Fallback-cheat-sheet.pdf Outdated Show resolved Hide resolved
docs/media/Timeout-cheat-sheet.pdf Outdated Show resolved Hide resolved
docs/community/cheat-sheets.md Outdated Show resolved Hide resolved
@martincostello martincostello added this to the v8.3.0 milestone Dec 5, 2023
Copy link
Member

@martincostello martincostello left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

These are great! 👏

Copy link
Contributor

@martintmk martintmk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

These looks great! Thanks @peter-csala

@martincostello martincostello merged commit c49ab55 into App-vNext:main Dec 5, 2023
17 checks passed
@peter-csala
Copy link
Contributor Author

peter-csala commented Dec 5, 2023

@martincostello The lower casing change did not work out well :D

I'll create a fixing PR soon.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants