Use NeoForge face data instead of custom unlit quad hooks #8322
+175
−338
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
embeddedt
force-pushed
the
use-native-unlit-quads
branch
from
99b3938 to
1dfd10f
Compare
62832
added a commit
to 62832/Fullblock-Energistics
that referenced
this pull request
Jan 12, 2025
StarskyXIII
pushed a commit
to StarskyXIII/Applied-Energistics-2
that referenced
this pull request
Jan 13, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This fixes compatibility issues with mods that need to implement model loading themselves (e.g. ModernFix when dynamic resources is enabled).
For reference, models were updated using:
find src/main/resources/assets/ae2/models -name \*.json | xargs sed -i 's/"unlit": true/"neoforge_data": {"block_light": 15, "sky_light": 15}/g'