-
Notifications
You must be signed in to change notification settings - Fork 0
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update the snakemake pipeline to run tierpsy tracker and begin documentation of pipeline in README #6
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good! Just a bunch of minor comments/suggested edis.
-e SHELL=/bin/bash \ | ||
-e HOME=/home/tierpsy_user \ | ||
-e PATH=/usr/local/bin:/usr/local/sbin:/usr/local/bin:/usr/sbin:/usr/bin:/sbin:/bin:/home/tierpsy_user/.local/bin \ | ||
-e TERM=xterm \ | ||
-e PWD=/DATA \ | ||
-e SHLVL=1 \ | ||
-e LIBGL_ALWAYS_INDIRECT=1 \ | ||
-e DOCKER_HOME=/home/tierpsy_user \ |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Is it possible to set some of these env vars in the dockerfile instead? That would de-clutter the snakefile a bit (and clarify which env vars don't need to be specific to this docker exec
command).
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I do not know how to do that, so I'll open an issue for this as well!
Edit: see #11
Co-authored-by: Keith Cheveralls <[email protected]> Signed-off-by: Taylor Reiter <[email protected]>
PR checklist
Fixes #123, Resolves #456
).conda
environments.Issues
Description
This PR adds a rule to run Tierpsy tracker to the snakefile. It includes instructions/documentation for Docker. I'm fully aware that this is a sub-par solution, but I think it's good enough for now.
I also started documented the pipeline in the README. I'll add more in future PRs.