Stop parameters page in Wiki from just disappearing #6576
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
so we exit after an error has happened rather than do more damage
prevents returning an empty set of commits which can make the Wiki's parameters page break
timtuxworth
suggested changes
Jan 27, 2025
| @@ -305,6 +305,8 @@ def fetch_commit_hash(version_link, board, file): | |||
| for i in commits_and_codes: | |||
| if commits_and_codes[i][0] != 'error': | |||
| commite_and_codes_cleanned[i] = commits_and_codes[i] | |||
| if len(commite_and_codes_cleanned) == 0: | |||
There was a problem hiding this comment.
cleaned (spelling) - ok I see it's a pre-existing wierdness, but an opportunity to fix it? (and commite)
There was a problem hiding this comment.
Not really a good time to fix this sort of thing. The variable needs a completely new name, not just a spelling fix :-)
... and I don't even know if "commite" comes from a language-other-than-English or is just a typo...
| @@ -1,9 +1,12 @@ | |||
| #!/bin/bash | |||
| # check for changes in docs and run sphinx | |||
|
|
|||
| set -e | |||
| set -x | |||
|
|
|||
There was a problem hiding this comment.
No, I'm leaving it like this deliberately. One of these is even called out in the commit messages...
update.sh
Outdated
| cp new_logmessages/$site.rst old_logmessages/$site.rst | ||
| changed=1 | ||
| fi | ||
| done | ||
|
|
||
| [ $changed = 1 ] || exit 0 | ||
| [ $changed = 1 ] || { | ||
| progress "Nothing changed; no rebuild required, exitting" |
also create a separate log file for the current build
we're always going to want to do this, and probably fold build_parameters.py into update.py
peterbarker
force-pushed
the
pr/build-parameters-fixes
branch
from
a23ac36 to
0a072b3
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
From what I've gleaned from the logs on the Wiki server, it is possible for build_parameters.py to parse out 0 versions to build from its scanning of the firmware server's directory listing pages.
This leads us to removing the parameters.rst file but not copying in a special "versioning" replacement for it based on the master branch.
So. Run update.sh with
-eso that it doesn't just rumble on if there's an error.Change build_parameters.py to exit with a non-zero exit code if there's ever an error in it.
Require at least one version/commit from each directory listing parsed from the firmware server.
Future enhancements here: