refactor(cardinal): consolidate test components #821
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![devin-ai-integration[bot]](https://avatars.githubusercontent.com/in/811515?s=60&v=4){kind=small}
…nvert message tests to table-driven format\n- Create TestMessageRegistration for duplicate scenarios\n- Consolidate error handling tests into TestTransactionProcessing\n- Add clear test case names and descriptions\n- Remove duplicate test functions Co-Authored-By: Scott Sunarto <[email protected]>
- Create cardinal/testsuite package for shared test components - Move LocationComponent to testsuite package - Update import references in test files - Fix gci formatting issues Co-Authored-By: Scott Sunarto <[email protected]>
Your org has enabled the Graphite merge queue for merging into mainAdd the label “graphite/merge” to the PR and Graphite will automatically add it to the merge queue when it’s ready to merge. You must have a Graphite account and log in to Graphite in order to use the merge queue. Sign up using this link. |
🤖 Devin AI EngineerI'll be helping with this pull request! Here's what you should know: ✅ I will automatically:
⚙️ Control Options:
Add "(aside)" to your comment to have me ignore it. |
|
Important Review skippedBot user detected. To trigger a single review, invoke the You can disable this status message by setting the 🪧 TipsChatThere are 3 ways to chat with CodeRabbit:
Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. CodeRabbit Commands (Invoked using PR comments)
Other keywords and placeholders
CodeRabbit Configuration File (
|
Co-Authored-By: Scott Sunarto <[email protected]>
![graphite-app[bot]](https://avatars.githubusercontent.com/in/158384?s=60&v=4){kind=small}
Comment on lines
33
to
41
| name: "handles negative coordinates", | ||
| loc: LocationComponent{ | ||
| X: -5, | ||
| Y: -15, | ||
| }, | ||
| x: -5, | ||
| y: -15, | ||
| wantName: "location", | ||
| }, |
There was a problem hiding this comment.
The LocationComponent uses uint64 fields which cannot store negative values, but this test attempts to use negative coordinates (-5, -15). Either the test values should be updated to use non-negative numbers, or if negative coordinates are a valid use case, the component fields should be changed to int64.
Spotted by Graphite Reviewer
Is this helpful? React 👍 or 👎 to let us know.
Co-Authored-By: Scott Sunarto <[email protected]>
Co-Authored-By: Scott Sunarto <[email protected]>
Co-Authored-By: Scott Sunarto <[email protected]>
Co-Authored-By: Scott Sunarto <[email protected]>
Co-Authored-By: Scott Sunarto <[email protected]>
Co-Authored-By: Scott Sunarto <[email protected]>
Co-Authored-By: Scott Sunarto <[email protected]>
Co-Authored-By: Scott Sunarto <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Consolidates scattered test components into a shared testutils package and improves test organization.
Link to Devin run: https://app.devin.ai/sessions/ec99bdb55f144590b1df311d347070ae
Changes: