Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix the working game and add image support (without testing) #254

Merged
merged 26 commits into from
Apr 19, 2024

Conversation

jjgancfer
Copy link
Contributor

This PR adds image support to the game and fixes many of the issues we had with it.

@jjgancfer jjgancfer self-assigned this Apr 19, 2024
@jjgancfer jjgancfer requested review from gony02 and Toto-hitori April 19, 2024 10:15
@jjgancfer jjgancfer added enhancement 🆕 New feature or request frontend 👁️ Frontend issue Visual Enhancements 🎨 Improving the looks labels Apr 19, 2024
Toto-hitori and others added 2 commits April 19, 2024 12:26
# Conflicts:
#	webapp/src/components/game/Game.js
#	webapp/src/tests/Dashboard.test.js
Copy link

Quality Gate Failed Quality Gate failed

Failed conditions
15.6% Coverage on New Code (required ≥ 80%)

See analysis details on SonarCloud

Copy link
Contributor

@gony02 gony02 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Perfect!!!

@gony02 gony02 merged commit 9512131 into develop Apr 19, 2024
1 of 2 checks passed
@jjgancfer jjgancfer deleted the fix/webapp/game branch April 22, 2024 17:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement 🆕 New feature or request frontend 👁️ Frontend issue Visual Enhancements 🎨 Improving the looks
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants