Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix/sonarcloud analysis #284

Merged
merged 6 commits into from
Apr 24, 2024
Merged

Fix/sonarcloud analysis #284

merged 6 commits into from
Apr 24, 2024

Conversation

Toto-hitori
Copy link
Contributor

  • added tests
  • removed unused imports
  • fixed some issues from sonar cloud

@Toto-hitori Toto-hitori added the backend ⚙️ Backend issue label Apr 24, 2024
@Toto-hitori Toto-hitori self-assigned this Apr 24, 2024
@sonarqubecloud SonarQubeCloud
Copy link

Quality Gate Failed Quality Gate failed

Failed conditions
71.4% Coverage on New Code (required ≥ 80%)

See analysis details on SonarCloud

@Toto-hitori Toto-hitori merged commit be45647 into develop Apr 24, 2024
1 of 2 checks passed
@Toto-hitori Toto-hitori deleted the fix/sonarcloud-analysis branch April 25, 2024 15:47
@Toto-hitori Toto-hitori mentioned this pull request Apr 29, 2024
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sergiorodriguezgarcia sergiorodriguezgarcia sergiorodriguezgarcia approved these changes

@UO283615 UO283615 UO283615 approved these changes

@jjgancfer jjgancfer Awaiting requested review from jjgancfer

@sergioqfeg1 sergioqfeg1 Awaiting requested review from sergioqfeg1

Assignees

@Toto-hitori Toto-hitori

Labels
backend ⚙️ Backend issue
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@Toto-hitori @UO283615 @sergiorodriguezgarcia