Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: changing language now changes game language #286

Merged
merged 1 commit into from
Apr 25, 2024
Merged

fix: changing language now changes game language #286

merged 1 commit into from
Apr 25, 2024

Conversation

jjgancfer
Copy link
Contributor

This PR should fix changing the language but not the game's language.

@jjgancfer jjgancfer added enhancement 🆕 New feature or request frontend 👁️ Frontend issue labels Apr 25, 2024
@jjgancfer jjgancfer added this to the Final presentation milestone Apr 25, 2024
@jjgancfer jjgancfer self-assigned this Apr 25, 2024
gony02
gony02 approved these changes Apr 25, 2024
View reviewed changes
Copy link
Contributor

@gony02 gony02 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good job 😁

@gony02 gony02 merged commit 4cdca2b into develop Apr 25, 2024
1 check passed
@sonarqubecloud SonarQubeCloud
Copy link

Quality Gate Passed Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
33.3% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarCloud

@jjgancfer jjgancfer deleted the fix/game/lang branch April 27, 2024 16:04
@jjgancfer jjgancfer mentioned this pull request Apr 29, 2024
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@GOLASOOO GOLASOOO GOLASOOO approved these changes

@gony02 gony02 gony02 approved these changes

@sergiorodriguezgarcia sergiorodriguezgarcia Awaiting requested review from sergiorodriguezgarcia

Assignees

@jjgancfer jjgancfer

Labels
enhancement 🆕 New feature or request frontend 👁️ Frontend issue
Projects
None yet
Milestone
Final presentation
Development

Successfully merging this pull request may close these issues.
3 participants
@jjgancfer @gony02 @GOLASOOO