Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

finished e2e integration #338

Merged
merged 26 commits into from
May 5, 2024
Merged

finished e2e integration #338

merged 26 commits into from
May 5, 2024

Conversation

Toto-hitori
Copy link
Contributor

  • finished fixing the rest of tests

GOLASOOO and others added 26 commits May 5, 2024 16:30
@GOLASOOO
test: added timeout to before all
2473a7c
@GOLASOOO
test: added ignore https errors
7f4fa18
@GOLASOOO
Merge remote-tracking branch 'origin/test/e2e' into test/e2e
25a84d5 
# Conflicts:
#	webapp/e2e/steps/playing_full_game_positive.steps.js
@GOLASOOO
Merge remote-tracking branch 'origin/test/e2e' into test/e2e
7eabc4b
@GOLASOOO
test: added register test cases
53c1ed3
@Toto-hitori
fix: about_positive_logged_user_seeing_about_screen.steps.js
e445f41
@Toto-hitori
fix: about_positive_non_logged_user_seeing_about_screen.steps.js
9a3254c
@Toto-hitori
fix: added timeout for pressing about button
efaaaef
@Toto-hitori
fix: removed about and changed stuff in login register negative
6e29997
@Toto-hitori
fix: simplified test
95346c2
@Toto-hitori
fix: login_register_negative_blank_email_credentials.steps.js
96aa9b5
@Toto-hitori
fix: ignoreHttpsErrors
925c2d6
@Toto-hitori
fix: fixed register
f820bc4
@Toto-hitori
fix: seeing tests
0a656c4
@Toto-hitori
fix: logout and about
4cc1089
@Toto-hitori
fix: uncommented https lines
baabe89
@Toto-hitori
fix: login register negative
13d23d4
@Toto-hitori
fix: run all tests
89f8204
@Toto-hitori
fix: some fixes tests
b1974fd
@Toto-hitori
fix:fixed login register negative
f5e9321
@Toto-hitori
fix:fixed logout positive logged user
5bfa032
@Toto-hitori
fix:fixed register
b4968c3
@Toto-hitori
fix:fixed register negative wrong email
322fca5
@Toto-hitori
fix:fixed register negative blank password
5ae916e
@Toto-hitori
fix: added timeout
0386a25
@Toto-hitori
fix: added timeout
6b424e3
@Toto-hitori Toto-hitori added the testing 🧪 Regarding testing label May 5, 2024
@Toto-hitori Toto-hitori requested review from jjgancfer and GOLASOOO May 5, 2024 19:26
@Toto-hitori Toto-hitori self-assigned this May 5, 2024
@sonarqubecloud SonarQubeCloud
Copy link

sonarqubecloud bot commented May 5, 2024

Quality Gate Passed Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
100.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarCloud

gony02
gony02 approved these changes May 5, 2024
View reviewed changes
Copy link
Contributor

@gony02 gony02 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good job 😄

@Toto-hitori Toto-hitori merged commit 09e9b14 into develop May 5, 2024
3 checks passed
@Toto-hitori Toto-hitori linked an issue May 6, 2024 that may be closed by this pull request
Integrate E2E tests into the CI pipeline #339
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jjgancfer jjgancfer jjgancfer approved these changes

@gony02 gony02 gony02 approved these changes

@GOLASOOO GOLASOOO Awaiting requested review from GOLASOOO

Assignees

@Toto-hitori Toto-hitori

Labels
testing 🧪 Regarding testing
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Integrate E2E tests into the CI pipeline
4 participants
@Toto-hitori @gony02 @jjgancfer @GOLASOOO