Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add jwt authentication support #83

Merged
merged 22 commits into from
Mar 7, 2024
Merged

Conversation

jjgancfer
Copy link
Contributor

This PR adds support to JWT authentication. It also comes with its own tests.

@jjgancfer jjgancfer added enhancement 🆕 New feature or request backend ⚙️ Backend issue frontend 👁️ Frontend issue labels Mar 5, 2024
@jjgancfer jjgancfer added this to the Second delivery milestone Mar 5, 2024
@jjgancfer jjgancfer self-assigned this Mar 5, 2024
@jjgancfer jjgancfer marked this pull request as draft March 5, 2024 13:07
@jjgancfer jjgancfer marked this pull request as ready for review March 5, 2024 15:16
@Toto-hitori
Copy link
Contributor

SonarCloud complaints because it finds no coverage for the code. What may be causing this?

@jjgancfer
Copy link
Contributor Author

SonarCloud complaints because it finds no coverage for the code. What may be causing this?

I don't know. The tests are in the same folder as the others. I am looking into this.

@jjgancfer jjgancfer force-pushed the feat/webapp/jwt-auth branch from 54c9330 to 7a22e7f Compare March 5, 2024 15:54
Copy link

sonarqubecloud bot commented Mar 6, 2024

Quality Gate Failed Quality Gate failed

Failed conditions
71.9% Coverage on New Code (required ≥ 80%)

See analysis details on SonarCloud

Copy link
Contributor

@gony02 gony02 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Everything is working and seems OK. Good job!!!

Copy link
Contributor

@sergiorodriguezgarcia sergiorodriguezgarcia left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It looks great! Congrats!

@gony02 gony02 merged commit d5aebf5 into develop Mar 7, 2024
1 of 2 checks passed
@Toto-hitori Toto-hitori deleted the feat/webapp/jwt-auth branch March 19, 2024 15:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backend ⚙️ Backend issue enhancement 🆕 New feature or request frontend 👁️ Frontend issue
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants