This adds a dedicated "Search" button to the UI for simple viewer. #111
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Addresses issues #78 & #98 A listener for search input doesn't work well with language input methods which convert words into kanji or Chinese characters. This adds a dedicated search button and ensures that the previous & next buttons are shown and hidden as required. It also prints out better syntax for the search information.
|
Fix for: #98 |
|
Adding a "Search" button is an innovative idea, but there is a small flaw in my test. If the target word only appears in the pages before the current page, clicking "Search" cannot trigger the display of "Prev" or "Next", and thus cannot search for the previous words. Considering that search boxes usually use two buttons, I submitted a pull request #112. Please see if it is acceptable? |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Addresses issues #78 & #98
A listener for search input doesn't work well
with language input methods which convert
words into kanji or Chinese characters.
This adds a dedicated search button and
ensures that the previous & next buttons
are shown and hidden as required.
It also prints out better syntax for the search
information.