Bug 707210: fitz: fix assertion on mutool on s390x #42
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
template_span_with_mask_3_general attemps to accelerate template_span_with_mask_N_general by accessing byte sequence dp and sp 4 bytes each, reinterpreting them as uint32_t sequence then calculating the result sequence 4 bytes each. The value of each 4 byte interpreted as uint32_t differs according to endianness, so fixing assertion expression as such. Fixes https://bugs.ghostscript.com/show_bug.cgi?id=707210 : `mutool draw -F png` assertion on s390x.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
template_span_with_mask_3_general attemps to accelerate template_span_with_mask_N_general
by accessing byte sequence dp and sp 4 bytes each, reinterpreting them as uint32_t sequence then calculating the result sequence 4 bytes each. The value of each 4 byte interpreted as uint32_t differs according to endianness, so fixing assertion expression as such.
Fixes https://bugs.ghostscript.com/show_bug.cgi?id=707210 :
mutool draw -F pngassertion on s390x.