Update SpecVersion to stop returning InternalError for nil errors (Ne…

…thermindEth#549) * fix starknet_specVersion handler
AryanGodara · Apr 2, 2024 · 02a8f45 · 02a8f45
1 parent 34a506f
commit 02a8f45
Show file tree

Hide file tree

Showing 2 changed files with 5 additions and 2 deletions.
diff --git a/rpc/version.go b/rpc/version.go
@@ -8,5 +8,8 @@ import "context"
 func (provider *Provider) SpecVersion(ctx context.Context) (string, error) {
 	var result string
 	err := do(ctx, provider.c, "starknet_specVersion", &result)
-	return result, Err(InternalError, err)
+	if err != nil {
+		return "", Err(InternalError, err)
+	}
+	return result, nil
 }
diff --git a/rpc/version_test.go b/rpc/version_test.go
@@ -20,7 +20,7 @@ func TestSpecVersion(t *testing.T) {
 		"mainnet": {},
 		"mock":    {},
 		"testnet": {{
-			ExpectedResp: "0.6.0",
+			ExpectedResp: "0.7.0",
 		}},
 	}[testEnv]