fixed WaitForTransactionReceipt error handling and revert TestWaitFor…

…TransactionReceipt changes
AryanGodara · May 17, 2024 · d6c9450 · d6c9450
1 parent a018e9f
commit d6c9450
Show file tree

Hide file tree

Showing 2 changed files with 4 additions and 3 deletions.
diff --git a/account/account.go b/account/account.go
@@ -534,7 +534,8 @@ func (account *Account) WaitForTransactionReceipt(ctx context.Context, transacti
 		case <-t.C:
 			receiptWithBlockInfo, err := account.TransactionReceipt(ctx, transactionHash)
 			if err != nil {
-				if errors.Is(err, rpc.ErrHashNotFound) {
+				rpcErr := err.(*rpc.RPCError)
+				if rpcErr.Code == rpc.ErrHashNotFound.Code && rpcErr.Message == rpc.ErrHashNotFound.Message {
 					continue
 				} else {
 					return nil, err

diff --git a/account/account_test.go b/account/account_test.go
@@ -1119,7 +1119,7 @@ func TestWaitForTransactionReceipt(t *testing.T) {
 	testSet := map[string][]testSetType{
 		"devnet": {
 			{
-				Timeout:         1, // Should poll 3 times
+				Timeout:         3, // Should poll 3 times
 				Hash:            new(felt.Felt).SetUint64(100),
 				ExpectedReceipt: nil,
 				ExpectedErr:     rpc.Err(rpc.InternalError, "Post \"http://0.0.0.0:5050/\": context deadline exceeded"),
@@ -1131,7 +1131,7 @@ func TestWaitForTransactionReceipt(t *testing.T) {
 		ctx, cancel := context.WithTimeout(context.Background(), time.Duration(test.Timeout)*time.Second)
 		defer cancel()
 
-		resp, err := acnt.WaitForTransactionReceipt(ctx, test.Hash, 2*time.Second)
+		resp, err := acnt.WaitForTransactionReceipt(ctx, test.Hash, 1*time.Second)
 		if test.ExpectedErr != nil {
 			require.Equal(t, test.ExpectedErr.Error(), err.Error())
 		} else {