Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

v1.4.2 release #56

Merged
merged 3 commits into from
Jan 30, 2025
Merged

v1.4.2 release #56

merged 3 commits into from
Jan 30, 2025

Conversation

tpcarman
Copy link
Contributor

Description

[1.4.2] - 2025-01-30

Related Issue

Fixed

  • Fix password shown in plain text (Fix #55)
  • Prevent execution from Windows PowerShell ISE (Fix #52)

Motivation and Context

How Has This Been Tested?

Tested in multiple lab and production environments with multiple AsBuiltReport modules

Screenshots (if appropriate):

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)

Checklist:

  • My code follows the code style of this project.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have read the CONTRIBUTING page.

## [1.4.2] - 2025-01-30

### Fixed
- Fix password shown in plain text (Fix [#55](#55))
- Fix typo
- Prevent execution from Windows PowerShell ISE (Fix [#52](#52))
Copy link

PSScriptAnalyzer results:

Errors: [0], Warnings: [29], Information: [1]


RuleName   : PSAvoidUsingWriteHost
Severity   : Warning
ScriptName : New-AsBuiltConfig.ps1
Line       : 29
Message    : File 'New-AsBuiltConfig.ps1' uses Write-Host. Avoid using 
             Write-Host because it might not work in all hosts, does not work 
             when there is no host, and (prior to PS 5.0) cannot be suppressed, 
             captured, or redirected. Instead, use Write-Output, Write-Verbose, 
             or Write-Information.

RuleName   : PSAvoidUsingWriteHost
Severity   : Warning
ScriptName : New-AsBuiltConfig.ps1
Line       : 30
Message    : File 'New-AsBuiltConfig.ps1' uses Write-Host. Avoid using 
             Write-Host because it might not work in all hosts, does not work 
             when there is no host, and (prior to PS 5.0) cannot be suppressed, 
             captured, or redirected. Instead, use Write-Output, Write-Verbose, 
             or Write-Information.

RuleName   : PSAvoidUsingWriteHost
Severity   : Warning
ScriptName : New-AsBuiltConfig.ps1
Line       : 31
Message    : File 'New-AsBuiltConfig.ps1' uses Write-Host. Avoid using 
             Write-Host because it might not work in all hosts, does not work 
             when there is no host, and (prior to PS 5.0) cannot be suppressed, 
             captured, or redirected. Instead, use Write-Output, Write-Verbose, 
             or Write-Information.

RuleName   : PSAvoidUsingWriteHost
Severity   : Warning
ScriptName : New-AsBuiltConfig.ps1
Line       : 44
Message    : File 'New-AsBuiltConfig.ps1' uses Write-Host. Avoid using 
             Write-Host because it might not work in all hosts, does not work 
             when there is no host, and (prior to PS 5.0) cannot be suppressed, 
             captured, or redirected. Instead, use Write-Output, Write-Verbose, 
             or Write-Information.

RuleName   : PSAvoidUsingWriteHost
Severity   : Warning
ScriptName : New-AsBuiltConfig.ps1
Line       : 45
Message    : File 'New-AsBuiltConfig.ps1' uses Write-Host. Avoid using 
             Write-Host because it might not work in all hosts, does not work 
             when there is no host, and (prior to PS 5.0) cannot be suppressed, 
             captured, or redirected. Instead, use Write-Output, Write-Verbose, 
             or Write-Information.

RuleName   : PSAvoidUsingWriteHost
Severity   : Warning
ScriptName : New-AsBuiltConfig.ps1
Line       : 46
Message    : File 'New-AsBuiltConfig.ps1' uses Write-Host. Avoid using 
             Write-Host because it might not work in all hosts, does not work 
             when there is no host, and (prior to PS 5.0) cannot be suppressed, 
             captured, or redirected. Instead, use Write-Output, Write-Verbose, 
             or Write-Information.

RuleName   : PSAvoidUsingWriteHost
Severity   : Warning
ScriptName : New-AsBuiltConfig.ps1
Line       : 74
Message    : File 'New-AsBuiltConfig.ps1' uses Write-Host. Avoid using 
             Write-Host because it might not work in all hosts, does not work 
             when there is no host, and (prior to PS 5.0) cannot be suppressed, 
             captured, or redirected. Instead, use Write-Output, Write-Verbose, 
             or Write-Information.

RuleName   : PSAvoidUsingWriteHost
Severity   : Warning
ScriptName : New-AsBuiltConfig.ps1
Line       : 75
Message    : File 'New-AsBuiltConfig.ps1' uses Write-Host. Avoid using 
             Write-Host because it might not work in all hosts, does not work 
             when there is no host, and (prior to PS 5.0) cannot be suppressed, 
             captured, or redirected. Instead, use Write-Output, Write-Verbose, 
             or Write-Information.

RuleName   : PSAvoidUsingWriteHost
Severity   : Warning
ScriptName : New-AsBuiltConfig.ps1
Line       : 76
Message    : File 'New-AsBuiltConfig.ps1' uses Write-Host. Avoid using 
             Write-Host because it might not work in all hosts, does not work 
             when there is no host, and (prior to PS 5.0) cannot be suppressed, 
             captured, or redirected. Instead, use Write-Output, Write-Verbose, 
             or Write-Information.

RuleName   : PSAvoidUsingWriteHost
Severity   : Warning
ScriptName : New-AsBuiltConfig.ps1
Line       : 150
Message    : File 'New-AsBuiltConfig.ps1' uses Write-Host. Avoid using 
             Write-Host because it might not work in all hosts, does not work 
             when there is no host, and (prior to PS 5.0) cannot be suppressed, 
             captured, or redirected. Instead, use Write-Output, Write-Verbose, 
             or Write-Information.

RuleName   : PSAvoidUsingWriteHost
Severity   : Warning
ScriptName : New-AsBuiltConfig.ps1
Line       : 151
Message    : File 'New-AsBuiltConfig.ps1' uses Write-Host. Avoid using 
             Write-Host because it might not work in all hosts, does not work 
             when there is no host, and (prior to PS 5.0) cannot be suppressed, 
             captured, or redirected. Instead, use Write-Output, Write-Verbose, 
             or Write-Information.

RuleName   : PSAvoidUsingWriteHost
Severity   : Warning
ScriptName : New-AsBuiltConfig.ps1
Line       : 152
Message    : File 'New-AsBuiltConfig.ps1' uses Write-Host. Avoid using 
             Write-Host because it might not work in all hosts, does not work 
             when there is no host, and (prior to PS 5.0) cannot be suppressed, 
             captured, or redirected. Instead, use Write-Output, Write-Verbose, 
             or Write-Information.

RuleName   : PSAvoidUsingWriteHost
Severity   : Warning
ScriptName : New-AsBuiltConfig.ps1
Line       : 207
Message    : File 'New-AsBuiltConfig.ps1' uses Write-Host. Avoid using 
             Write-Host because it might not work in all hosts, does not work 
             when there is no host, and (prior to PS 5.0) cannot be suppressed, 
             captured, or redirected. Instead, use Write-Output, Write-Verbose, 
             or Write-Information.

RuleName   : PSAvoidUsingWriteHost
Severity   : Warning
ScriptName : New-AsBuiltConfig.ps1
Line       : 208
Message    : File 'New-AsBuiltConfig.ps1' uses Write-Host. Avoid using 
             Write-Host because it might not work in all hosts, does not work 
             when there is no host, and (prior to PS 5.0) cannot be suppressed, 
             captured, or redirected. Instead, use Write-Output, Write-Verbose, 
             or Write-Information.

RuleName   : PSAvoidUsingWriteHost
Severity   : Warning
ScriptName : New-AsBuiltConfig.ps1
Line       : 209
Message    : File 'New-AsBuiltConfig.ps1' uses Write-Host. Avoid using 
             Write-Host because it might not work in all hosts, does not work 
             when there is no host, and (prior to PS 5.0) cannot be suppressed, 
             captured, or redirected. Instead, use Write-Output, Write-Verbose, 
             or Write-Information.

RuleName   : PSPossibleIncorrectComparisonWithNull
Severity   : Warning
ScriptName : New-AsBuiltConfig.ps1
Line       : 85
Message    : $null should be on the left side of equality comparisons.

RuleName   : PSPossibleIncorrectComparisonWithNull
Severity   : Warning
ScriptName : New-AsBuiltConfig.ps1
Line       : 90
Message    : $null should be on the left side of equality comparisons.

RuleName   : PSPossibleIncorrectComparisonWithNull
Severity   : Warning
ScriptName : New-AsBuiltConfig.ps1
Line       : 95
Message    : $null should be on the left side of equality comparisons.

RuleName   : PSPossibleIncorrectComparisonWithNull
Severity   : Warning
ScriptName : New-AsBuiltConfig.ps1
Line       : 118
Message    : $null should be on the left side of equality comparisons.

RuleName   : PSPossibleIncorrectComparisonWithNull
Severity   : Warning
ScriptName : New-AsBuiltConfig.ps1
Line       : 131
Message    : $null should be on the left side of equality comparisons.

RuleName   : PSUseShouldProcessForStateChangingFunctions
Severity   : Warning
ScriptName : New-AsBuiltConfig.ps1
Line       : 1
Message    : Function 'New-AsBuiltConfig' has verb that could change system 
             state. Therefore, the function has to support 'ShouldProcess'.

RuleName   : PSAvoidUsingWriteHost
Severity   : Warning
ScriptName : New-AsBuiltReport.ps1
Line       : 357
Message    : File 'New-AsBuiltReport.ps1' uses Write-Host. Avoid using 
             Write-Host because it might not work in all hosts, does not work 
             when there is no host, and (prior to PS 5.0) cannot be suppressed, 
             captured, or redirected. Instead, use Write-Output, Write-Verbose, 
             or Write-Information.

RuleName   : PSAvoidUsingWriteHost
Severity   : Warning
ScriptName : New-AsBuiltReport.ps1
Line       : 358
Message    : File 'New-AsBuiltReport.ps1' uses Write-Host. Avoid using 
             Write-Host because it might not work in all hosts, does not work 
             when there is no host, and (prior to PS 5.0) cannot be suppressed, 
             captured, or redirected. Instead, use Write-Output, Write-Verbose, 
             or Write-Information.

RuleName   : PSAvoidUsingWriteHost
Severity   : Warning
ScriptName : New-AsBuiltReport.ps1
Line       : 359
Message    : File 'New-AsBuiltReport.ps1' uses Write-Host. Avoid using 
             Write-Host because it might not work in all hosts, does not work 
             when there is no host, and (prior to PS 5.0) cannot be suppressed, 
             captured, or redirected. Instead, use Write-Output, Write-Verbose, 
             or Write-Information.

RuleName   : PSAvoidUsingWriteHost
Severity   : Warning
ScriptName : New-AsBuiltReport.ps1
Line       : 409
Message    : File 'New-AsBuiltReport.ps1' uses Write-Host. Avoid using 
             Write-Host because it might not work in all hosts, does not work 
             when there is no host, and (prior to PS 5.0) cannot be suppressed, 
             captured, or redirected. Instead, use Write-Output, Write-Verbose, 
             or Write-Information.

RuleName   : PSAvoidUsingWriteHost
Severity   : Warning
ScriptName : New-AsBuiltReport.ps1
Line       : 411
Message    : File 'New-AsBuiltReport.ps1' uses Write-Host. Avoid using 
             Write-Host because it might not work in all hosts, does not work 
             when there is no host, and (prior to PS 5.0) cannot be suppressed, 
             captured, or redirected. Instead, use Write-Output, Write-Verbose, 
             or Write-Information.

RuleName   : PSUseShouldProcessForStateChangingFunctions
Severity   : Warning
ScriptName : New-AsBuiltReport.ps1
Line       : 1
Message    : Function 'New-AsBuiltReport' has verb that could change system 
             state. Therefore, the function has to support 'ShouldProcess'.

RuleName   : PSAvoidUsingPlainTextForPassword
Severity   : Warning
ScriptName : New-AsBuiltReport.ps1
Line       : 141
Message    : Parameter '$Password' should use SecureString, otherwise this will 
             expose sensitive information. See ConvertTo-SecureString for more 
             information.

RuleName   : PSUseShouldProcessForStateChangingFunctions
Severity   : Warning
ScriptName : New-AsBuiltReportConfig.ps1
Line       : 1
Message    : Function 'New-AsBuiltReportConfig' has verb that could change 
             system state. Therefore, the function has to support 
             'ShouldProcess'.

RuleName   : PSUseOutputTypeCorrectly
Severity   : Information
ScriptName : New-AsBuiltConfig.ps1
Line       : 258
Message    : The cmdlet 'New-AsBuiltConfig' returns an object of type 
             'System.Collections.Hashtable' but this type is not declared in 
             the OutputType attribute.

@tpcarman tpcarman merged commit a88b449 into master Jan 30, 2025
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant