-
Notifications
You must be signed in to change notification settings - Fork 94
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
add query param support #973
Conversation
…astar-apps into connection-customization
@krisz4 Could you fix the build error? |
@impelcrypto Added the requested changes |
@krisz4 Can you allow us in? |
@gluneau Sorry updated the url. I get a 404 error when trying to open the link. Doesn't seem related to the PR. If I try to open any url other than the base url https://astar-portal-dun.vercel.app I get this error. E.g. https://astar-portal-dun.vercel.app/astar/assets same 404 error. Any idea why this happens? Doesn't happen when tested locally, just on vercel deploy |
I think this only works for |
@impelcrypto Added some fixes to the PR. Can you check again? |
@krisz4 |
@impelcrypto Can't reproduce on a fresh build. Is there any cached/preset value I should be aware of? How can I reproduce this issue? y26oj6.mp4 |
Closed as stale |
Pull Request Summary
Describe what changes this pull request makes to the repository:
The recent update to our system introduces a customizable wallet connection flow that enhances our ability to integrate smoothly with various platforms.
Now, you can fine-tune the assets path URL with new parameters to streamline the wallet selection:
https://astar-portal-dun.vercel.app/astar/assets?nativeWallets=gridlock&evmWallets=gridlockEvm%2Cmetamask&multisigWallets=null
Here’s what each parameter does:
nativeWallets
: Narrows down the list of native wallets to only those specified. Accepts a single entry or a list separated by commas (use%2C
for encoding the comma in URLs).evmWallets
: Filters the list of EVM wallets in the same way asnativeWallets
.multisigWallets
: If set tonull
or falsy value, it will hide this category from the display.If you don't use a parameter, the full array of wallets will be displayed without any filter.
For a more streamlined experience that skips the standard selection, you can directly connect to a wallet using:
https://astar-portal-dun.vercel.app/astar/assets?selectedWallet=gridlock&selectedWalletType=native
selectedWallet
: This should be a string matching one of the wallets in the SupportWallet list.selectedWalletType
: Choose between 'native' or 'evm'.By including both parameters, the system will bypass the usual selection process and connect directly to the specified wallet. It’s essential to provide both to ensure the process works seamlessly.
Check list
This pull request makes the following changes:
Adds