Preferences & Config editors #139
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
white-axe
requested changes
Jul 12, 2024
Produces a toast when failing to load scripts, and when modified marks scripts as modified
white-axe
approved these changes
Jul 12, 2024
5 tasks
MolassesLover
pushed a commit
to MolassesLover/luminol-molasses
that referenced
this pull request
Jul 23, 2024
* Kinda port over preferences editor from old branch * Fix catppuccin visuals * Change theme handling * Fix theme saving * Make use_ron option a combobox * Add format-agnostic handler * Don't pass extension to handler * kinda implement format conversion * Actually get data conversion to work * Change warning message * Use indexmap for rtp paths * Fix some wasm things * Make config window set modified flag * Change how scripts_path functions Produces a toast when failing to load scripts, and when modified marks scripts as modified
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Connections
#43
#45
Description
#43 and #45 changed how configuring Luminol worked, but left the configuration editors in an unfinished state. This PR fixes that!
As well as fixing up the config editors, this PR adds support for loading other data formats (but not converting projects, that requires either another out-of-project manager, or changes to the path cache to recognize file extensions when present)
Testing
StandardRTP, then open a project that requires itChecklist
cargo fmt.cargo clippy. If applicable, add:--target wasm32-unknown-unknown -Z build-std=std,panic_abortcargo build --releasetrunk build --release