Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Minor bug fixes #2

Merged
merged 7 commits into from
Mar 30, 2015
Merged

Minor bug fixes #2

merged 7 commits into from
Mar 30, 2015

Conversation

keflavich
Copy link
Contributor

@dcolombo I've fixed a few issues with imports here. I think you were doing %run -i orion2scimes.py after having run from pylab import *; that's not generally true so I've fixed that stuff up.

I'm still running into one issue:

Traceback (most recent call last):
  File "/Users/adam/work/scimes/scimes/orion2scimes.py", line 266, in <module>
    showdendro(d, gmcs.clusters)
  File "/Users/adam/work/scimes/scimes/orion2scimes.py", line 52, in showdendro
    p.plot_tree(ax, structure=cores_idx[i], color=cols[i], lw=3)
  File "/Users/adam/repos/astrodendro/astrodendro/plot.py", line 103, in plot_tree
    lines = self.get_lines(structures=structure, **kwargs)
  File "/Users/adam/repos/astrodendro/astrodendro/plot.py", line 193, in get_lines
    if type(structures[0]) is int:
TypeError: 'int' object has no attribute '__getitem__'

> /Users/adam/repos/astrodendro/astrodendro/plot.py(193)get_lines()
    192             if subtree:
--> 193                 if type(structures[0]) is int:
    194                     structure = self.dendrogram[structures[0]]

which could be a genuine bug in astrodendro or it could be that we're passing the wrong things to the plotter

@low-sky
Copy link
Contributor

low-sky commented Oct 22, 2014

👍 to me
It looks like a good beginning of a cleanup

@dcolombo
Copy link
Contributor

Thanks for this Adam!

About the bug, I am using the 0.1.0 version of astrodendro and I am not getting the error...
Checking on the dendrogram plotting, on the astrodendro website, it seems that the plotting procedure is called in the right way...

@keflavich
Copy link
Contributor Author

I think you don't have the latest dev version of astrodendro - there was a bug introduced, so I submitted this fix: dendrograms/astrodendro#133

keflavich and others added 2 commits November 14, 2014 21:26
@dcolombo dcolombo merged commit 5a1584d into Astroua:master Mar 30, 2015
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants