refactor: make optional

AtB-AS · Oct 23, 2024 · 989e6e9 · 989e6e9
1 parent 010e01a
commit 989e6e9
Show file tree

Hide file tree

Showing 2 changed files with 3 additions and 5 deletions.
diff --git a/schema-definitions/other.json b/schema-definitions/other.json
@@ -9,8 +9,7 @@
     },
     "contactPhoneNumber": {
       "type": "string",
-      "pattern": "^\\+\\d{1,3}\\d{1,14}$",
-      "default": ""
+      "pattern": "^\\+\\d{1,3}\\d{1,14}$"
     },
     "enableNynorsk": {
       "type": "boolean"
@@ -198,8 +197,7 @@
     }
   },
   "required": [
-    "vatPercent",
-    "contactPhoneNumber"
+    "vatPercent"
   ],
   "additionalProperties": false,
   "$schema": "http://json-schema.org/draft-07/schema#"

diff --git a/src/other.ts b/src/other.ts
@@ -7,7 +7,7 @@ export const LoginMethod = z.enum(['otp', 'email', 'vipps']);
 export const Other = z.object({
   vatPercent: z.number(),
   enableTokenToggleRestrictions: z.boolean().optional(),
-  contactPhoneNumber: z.string().regex(/^\+\d{1,3}\d{1,14}$/).default(""),
+  contactPhoneNumber: z.string().regex(/^\+\d{1,3}\d{1,14}$/).optional(),
   enableNynorsk: z.boolean().optional(),
   tokenToggleMaxLimit: z.number().optional(),
   travelcardNumberLength: z.number().default(16),